Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix early abort on files deletion loop #363

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

speed47
Copy link
Contributor

@speed47 speed47 commented Jul 21, 2021

Closes #352
Closes #353

@speed47
Copy link
Contributor Author

speed47 commented Jul 21, 2021

Currently being tested to ensure it does fix the problem as it should.

@camathieu
Copy link
Member

Let me know how it goes, I'll make a new release if you like

@speed47
Copy link
Contributor Author

speed47 commented Jul 21, 2021

It works, all the files older than 30 days finally vanished from the FS :)

Note that a better version of the patch would probably handle "file not found" errors differently than other errors, as "file not found" would imply that the file might have been deleted manually, so we should just ignore the error and delete the row from the db.

For this, backends would need to return some specific well-known error (or return another flag appart from the error) so that it can be catched and handled properly.

It just means we have some dead rows, I can live with that in the meantime :)

@speed47 speed47 marked this pull request as ready for review July 21, 2021 21:01
@camathieu
Copy link
Member

no more travis builds :'(

@speed47
Copy link
Contributor Author

speed47 commented Jul 21, 2021

no more travis builds :'(

Aww, yep :/ Hopefully migrating to GitHub Actions is not too painful starting from the workflow you had with travis

@camathieu
Copy link
Member

I ran tests locally and it seems fine, we might want add a test case though.
I'll try to take a look at GA tomorrow or Friday and to cut a 1.3.2 release with the last few patches.

@camathieu
Copy link
Member

Thanks for the patch :)

@bodji bodji force-pushed the master branch 3 times, most recently from 7d682b0 to eb5b027 Compare September 24, 2021 16:14
@bodji bodji force-pushed the master branch 18 times, most recently from 1c13484 to fe85ed3 Compare November 22, 2021 14:49
@bodji bodji force-pushed the master branch 6 times, most recently from 6e277df to bdf0af1 Compare November 22, 2021 15:18
@camathieu camathieu merged commit bdde088 into root-gg:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not deleting files on filesystem Unable to delete files
2 participants