[ci] add zizmor to CI - #350
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR hardens the CI/CD security posture by adding a new zizmor static analysis workflow, applying ChangesCI Security Hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8b18764 to
de92489
Compare
Add a zizmor security-analysis workflow (ported from coop) that audits our workflows on push to main and on PRs. Apply zizmor's recommended hardening to the existing workflows: - set least-privilege top-level `permissions` and scope elevated permissions to the jobs that need them (mdbook pages/id-token) - `persist-credentials: false` on all checkouts - pass interpolated values through `env:` instead of inlining them in run scripts to avoid template injection - disable uv cache in the release workflow and upload release assets via `gh release upload` Add a 7-day Dependabot cooldown for both the uv and github-actions ecosystems, which zizmor flags as missing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
de92489 to
45e54a4
Compare
| echo "**Tags:**" >> $GITHUB_STEP_SUMMARY | ||
| echo '```' >> $GITHUB_STEP_SUMMARY | ||
| echo "${{ steps.meta.outputs.tags }}" >> $GITHUB_STEP_SUMMARY | ||
| echo "$TAGS" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
thank you zizmor 🙏
|
@juanmrad already reviewed my equivalent PR in Coop and made some good suggestions that are incorporated here. So I'm going to go ahead and merge, but please let me know if there's anything I can improve here! |
What
This is an equivalent to this PR in Coop. It introduces zizmor, a very neat static analysis tool for GitHub Actions.
This PR:
Testing
Mostly, you should see CI pass!
There are some workflows I can't test with the changes, like
release-osprey-rpc.yml. We'll have to keep an eye on those the next time they run. (But I don't believe my changes will cause issues).🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Chores