Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change path params with pattern #98

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

agungcandra
Copy link
Contributor

Regarding this issue #97

After checking on the issue, the issue is when using resource path, memory usage of the application is increased gradually since every request that processed by service will have new entries on prometeus metrics

After check on grpc-gateway documentation
https://grpc-ecosystem.github.io/grpc-gateway/docs/operations/annotated_context/

It seems using pattern is much more suitable, since the same pattern can be grouped on the same entries

@agungcandra agungcandra changed the title feat: change path params with pattern fix: change path params with pattern Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.57% 🎉

Comparison is base (7c9248f) 84.15% compared to head (9d6005e) 84.72%.
Report is 2 commits behind head on master.

❗ Current head 9d6005e differs from pull request most recent head d3aef8c. Consider uploading reports for the commit d3aef8c to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   84.15%   84.72%   +0.57%     
==========================================
  Files          20       20              
  Lines        1571     1578       +7     
==========================================
+ Hits         1322     1337      +15     
+ Misses        213      205       -8     
  Partials       36       36              
Files Changed Coverage Δ
boot/gw_server_options.go 96.85% <85.71%> (+6.76%) ⬆️
middleware/common.go 96.51% <100.00%> (ø)
middleware/timeout/server_interceptor.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongxuny dongxuny merged commit d4d0cc5 into rookie-ninja:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants