Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #593 #594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

akshay-vashishtha
Copy link

@akshay-vashishtha akshay-vashishtha commented Jun 22, 2023

The solution to the open issue is mentioned at #593 (comment). To address the problem when using an Excel file with a custom data type, the roo gem was unable to convert it into an integer or float. Therefore, I made changes to the create_date mechanism to identify such cases. Now, if we encounter an exact date instead of a number, the string will be parsed using the Date parser to ensure proper conversion.

@akshay-vashishtha akshay-vashishtha changed the title Fix excel date Fix excel date [ resolved the open issue mentioned at #593 (comment).] Jun 22, 2023
@akshay-vashishtha akshay-vashishtha changed the title Fix excel date [ resolved the open issue mentioned at #593 (comment).] Fix excel date Jun 22, 2023
@akshay-vashishtha akshay-vashishtha changed the title Fix excel date Fix excel custom data type date issue #593 Jun 22, 2023
@akshay-vashishtha akshay-vashishtha changed the title Fix excel custom data type date issue #593 Fix issue #593 Jun 22, 2023
@patrickkulling
Copy link
Contributor

@akshay-vashishtha can you please add a suite of tests to validate the previous + new behaviour

@ldodds
Copy link

ldodds commented Nov 7, 2023

We're encountering this issue with some dates in XLSX files. In our case, the excelx_value value for the cell is returning 2023-10-04T00:00:00. I've confirmed that the branch fixes the date parsing issue. Would be great to get this merged if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants