Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_csv in the README is misleading #389

Closed
bluengreen opened this issue Apr 24, 2017 · 4 comments
Closed

to_csv in the README is misleading #389

bluengreen opened this issue Apr 24, 2017 · 4 comments
Labels
documentation

Comments

@bluengreen
Copy link

The to_csv description in the README gives no indication of what params are expected. The way it reads is you just provide it the .to_csv method.
@tgturner
Copy link
Contributor

I agree, the to_csv method, as well as some others, could use improved documentation. We would love it if you could open a PR.

@Mifrill
Copy link
Contributor

Mifrill commented Oct 17, 2018

looks like it should becomes file content against the boolean true, as similar as sio.read, isn't it?

roo/lib/roo/formatters/csv.rb

Line 9 in 8f65109

true

Mifrill added a commit to Mifrill/roo that referenced this issue Oct 17, 2018
@Mifrill
fixes roo-rb#389 #to_csv changed predefined arguments and add documen…
837d273 
…tation
@Mifrill Mifrill mentioned this issue Oct 17, 2018
Merged
Mifrill added a commit to Mifrill/roo that referenced this issue Oct 17, 2018
@Mifrill
fixes roo-rb#389 #to_csv: changed predefined argument and add documen…
bcadde3 
…tation
Mifrill added a commit to Mifrill/roo that referenced this issue Oct 17, 2018
@Mifrill
fixes roo-rb#389 #to_csv: changed predefined arguments and add docume…
9dc1ac3 
…ntation
Mifrill added a commit to Mifrill/roo that referenced this issue Nov 14, 2018
@Mifrill
fixes roo-rb#389 #to_csv: changed predefined arguments and add docume…
23e831d 
…ntation
@Mifrill
Copy link
Contributor

Mifrill commented Nov 14, 2018

@tgturner hi, sorry to bother you, but can you look at pr? thanks for your time

Mifrill added a commit to Mifrill/roo that referenced this issue Apr 7, 2019
@Mifrill
roo-rb#389 fix grammar
f56f0c4
@Mifrill
Copy link
Contributor

Mifrill commented Feb 11, 2021

any updates on this?

Mifrill added a commit to Mifrill/roo that referenced this issue Mar 12, 2022
@Mifrill
roo-rb#389 fix grammar
9a40dad
simonoff added a commit that referenced this issue Mar 14, 2024
@simonoff
Merge pull request #469 from Mifrill/issue_389
3d24c11 
fixes #389 #to_csv: changed predefined arguments and add documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bluengreen @tgturner @Mifrill