Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Image] Add fit and aspect props #16

Merged
merged 2 commits into from
Jun 4, 2024
Merged

[Image] Add fit and aspect props #16

merged 2 commits into from
Jun 4, 2024

Conversation

deebov
Copy link
Contributor

@deebov deebov commented Jun 4, 2024

This PR adds support for fit and aspect props:

  • fit specifies how the image should fill the available space (related to the object-fit CSS property)
  • aspect specifies the aspect ratio the image wrapper element should keep (related to the aspect-ratio CSS property)

@deebov deebov self-assigned this Jun 4, 2024
@deebov deebov requested review from colodenn, leo and NuroDev June 4, 2024 12:10
Copy link

github-actions bot commented Jun 4, 2024

Released an experimental package:

bun add react-ronin@add-fit-aspect-experimental

This package will be removed after the pull request has been merged.

@deebov deebov marked this pull request as ready for review June 4, 2024 13:31
@deebov deebov merged commit 85f4a6b into main Jun 4, 2024
5 checks passed
@deebov deebov deleted the add-fit-aspect branch June 4, 2024 15:41
@deebov deebov changed the title Add fit and aspect props [Image] Add fit and aspect props Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants