Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved bundle splitting #62

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Improved bundle splitting #62

merged 2 commits into from
Jun 12, 2024

Conversation

leo
Copy link
Member

@leo leo commented Jun 12, 2024

This change contributes to closing RON-944 by making it possible to import our package in Node.js again.

Unfortunately Node.js does not allow for importing files without their file extension when in ESM mode, so if we want to leave our file extensions away in the source code (which we want to do), we need to use a tool other than tsc to build the project, as tsc is not capable of adding file extensions to imports.

Copy link

Released an experimental package:

bun add ronin@leo-ron-944-experimental

This package will be removed after the pull request has been merged.

@leo leo added the enhancement New feature or request label Jun 12, 2024
@leo leo marked this pull request as ready for review June 12, 2024 16:47
@leo leo enabled auto-merge (squash) June 12, 2024 16:47
@leo leo disabled auto-merge June 12, 2024 17:13
@leo leo enabled auto-merge (squash) June 12, 2024 17:16
@leo leo merged commit 4026c4e into main Jun 12, 2024
5 checks passed
@leo leo deleted the leo/ron-944 branch June 12, 2024 17:22
@leo leo mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants