Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not provide a default Content-Type #27

Merged
merged 5 commits into from
May 13, 2024
Merged

Do not provide a default Content-Type #27

merged 5 commits into from
May 13, 2024

Conversation

deebov
Copy link
Contributor

@deebov deebov commented May 13, 2024 •
edited
Loading

Closes RON-917.

Changes:

  • Do not provide the server with a default Content-Type header if we cannot extract it from the given storable value
  • Improve the types for setting a blob property when creating or setting a record with a blob field

@deebov deebov self-assigned this May 13, 2024
@deebov deebov requested review from juriadams, leo and NuroDev May 13, 2024 16:20
@github-actions GitHub Actions
Copy link

Released an experimental package:

bun add ronin@dbov-ron-917-experimental

This package will be removed after the pull request has been merged.

@deebov deebov marked this pull request as ready for review May 13, 2024 16:57
leo
leo requested changes May 13, 2024
View reviewed changes
src/types/codegen.ts Outdated Show resolved Hide resolved
@leo leo merged commit da6ed42 into main May 13, 2024
5 checks passed
@leo leo deleted the dbov/ron-917 branch May 13, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo leo leo approved these changes

@juriadams juriadams Awaiting requested review from juriadams

@NuroDev NuroDev Awaiting requested review from NuroDev

Assignees

@deebov deebov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deebov @leo