Skip to content

Conversation

@minh-bq
Copy link
Contributor

@minh-bq minh-bq commented Feb 18, 2025

The new blst version fixes this build issue with go1.24.

../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:207:11: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:310:15: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:430:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:434:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:438:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:442:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:448:12: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:460:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:465:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:474:12: cannot define new methods on non-local type P2Affine

Reference:

The new blst version fixes this build issue with go1.24.

../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:207:11: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:310:15: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:430:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:434:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:438:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:442:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:448:12: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:460:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:465:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:474:12: cannot define new methods on non-local type P2Affine

Reference:
- blst commit: supranational/blst@df47c4c
- go-ethereum commit: ethereum/go-ethereum@24ed0b5
Copy link
Contributor

@chiphamskymavis chiphamskymavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minh-bq minh-bq merged commit f60c269 into ronin-chain:master Feb 18, 2025
1 check passed
@minh-bq minh-bq deleted the bump-blst branch February 18, 2025 08:37
huyngopt1994 pushed a commit that referenced this pull request Feb 25, 2025
The new blst version fixes this build issue with go1.24.

../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:207:11: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:310:15: cannot define new methods on non-local type SecretKey
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:430:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:434:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:438:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:442:11: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:448:12: cannot define new methods on non-local type Fp12
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:460:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:465:11: cannot define new methods on non-local type P1Affine
../../go/pkg/mod/github.com/supranational/[email protected]/bindings/go/blst.go:474:12: cannot define new methods on non-local type P2Affine

Reference:
- blst commit: supranational/blst@df47c4c
- go-ethereum commit: ethereum/go-ethereum@24ed0b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants