Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: innovation zone #6

Merged
merged 7 commits into from
Aug 26, 2024
Merged

feat: innovation zone #6

merged 7 commits into from
Aug 26, 2024

Conversation

thaixuandang
Copy link
Collaborator

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

Base automatically changed from feature/remove-nft-commands to release/v1.0.0 August 26, 2024 08:38
@thaixuandang thaixuandang merged commit d2a7d23 into release/v1.0.0 Aug 26, 2024
0 of 2 checks passed
@thaixuandang thaixuandang deleted the feature/innovation-zone branch August 26, 2024 08:43
TuDo1403
TuDo1403 reviewed Sep 6, 2024
View reviewed changes
src/governance/KatanaGovernance.sol
uint40 private constant AUTHORIZED = type(uint40).max;

/// @dev The factory contract.
IKatanaV2Factory private _factory;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to _v2Factory

@thaixuandang
Copy link
Collaborator Author

All comments are resolved in #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtaskymaviscom khanhtaskymaviscom khanhtaskymaviscom left review comments

@TuDo1403 TuDo1403 TuDo1403 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaixuandang @TuDo1403 @khanhtaskymaviscom