Fix Windows Smoke test harness spawning - #63
Merged
ronak-guliani merged 1 commit intoJul 27, 2026
Merged
Conversation
Resolve executable paths through the shared Windows spawn helper so Bun test fixtures receive intact arguments and the oxlint harness executes its Windows shim. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
size:S
vouch:trusted
ronak-guliani
merged commit Jul 27, 2026
18e5b64
into
feature/agent-browser-automation-port
5 of 8 checks passed
ronak-guliani
added a commit
that referenced
this pull request
Jul 27, 2026
* Add shared MCP preview automation * Refine collaborative browser preview Co-authored-by: codex <codex@users.noreply.github.com> * Refactor MCP services into top-level modules - Move MCP session registry and preview broker out of `Layers/` and `Services/` - Update imports, tests, and server wiring to use the new module layout * Refactor desktop preview IPC onto shared manager - Move preview session and IPC wiring into the new preview module - Tighten IPC validation with schema-based handlers - Update preview asset paths and tests for the browser preview port * Port preview manager to Effect-based browser sessions - derive preview partitions through `BrowserSession` - serialize session state and async preview control flow - update tests for screenshot, automation, and partition behavior * Scope preview listeners and control sessions - Tie preview and debugger listeners to Effect scopes - Factor shared automation helpers for snapshot and input handling - Improve cleanup for browser preview sessions and port scanning * Add SWR preview session state and resubscribe handling - Fetch preview sessions through atom-backed SWR state - Recover browser preview sessions after reconnects - Ignore older streamed snapshots when SWR revalidates * Prevent stale preview snapshots from resurrecting sessions - Track preview store revisions per thread - Ignore stale SWR results while revalidating - Avoid restoring closed sessions from outdated data * Route preview automation through live owner streams (pingdotgg#3548) Co-authored-by: codex <codex@users.noreply.github.com> * [codex] Fix preview automation edge cases (pingdotgg#3561) Co-authored-by: codex <codex@users.noreply.github.com> * Stabilize preview browser surfaces, automation, and recording (pingdotgg#3565) * Resolve localhost preview URLs for remote environments (pingdotgg#4011) Co-authored-by: codex <codex@users.noreply.github.com> * fix(desktop): allow clipboard writes in the preview browser (pingdotgg#3889) * fix(preview): preserve direct localhost navigation (pingdotgg#3939) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> * Add preview color scheme controls and simplify project grouping (pingdotgg#4385) Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat: port agent-driven browser automation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix standalone desktop workspace dependencies (#57) Exclude workspace protocol dependencies from staged desktop packaging manifests because their compiled code is already bundled into the artifact and pnpm cannot resolve them outside the monorepo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Windows test harness spawning (#63) Resolve executable paths through the shared Windows spawn helper so Bun test fixtures receive intact arguments and the oxlint harness executes its Windows shim. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Carlos Rico-Ospina <carlosricojr@gmail.com> Co-authored-by: Chris Michael Guzman <67719167+Chrrxs@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
Depends on #55 (
feature/agent-browser-automation-port); this is a focused stacked follow-up and should merge into that branch.Windows failure root cause
Windows Smoke was already failing on the first #55 commit (
cae61af) and failed identically after the browser-port changes. ACP and Codex test fixtures launched Bun throughcmd.exe, which corrupts their Windows path argument and exits with code 1. The oxlint harness invoked a POSIX-only shim path, sooxlintcould not be spawned on Windows.This reuses
resolveWindowsSpawnto resolve executables and only use a shell for batch shims.Validation
pnpm fmt:checkpnpm lintpnpm typecheckpnpm testpnpm --filter '!@t3tools/mobile' -r --if-present run test(Windows Smoke test equivalent)\n-pnpm build:desktop\n-node scripts/clean.ts(Windows Smoke clean step)