fix(mobile): cherry-pick upstream work-log and outbox fixes - #305
Merged
Conversation
…tgg#9911) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#10173) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…ing (pingdotgg#10210) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…ingdotgg#10245) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The cherry-picked changes match their upstream fixes and include focused regression coverage.
Pull request overview
Cherry-picks six upstream mobile reliability and UI fixes.
Changes:
- Improves work-log expansion, shimmer, spacing, sizing, and edge fades.
- Resumes diff highlighting after oversized lines.
- Retains queued tasks after transient delivery failures.
File summaries
| File | Description |
|---|---|
apps/mobile/src/state/thread-outbox.test.ts |
Tests retry classification. |
apps/mobile/src/state/thread-outbox-model.ts |
Classifies transient failures by tag. |
apps/mobile/src/lib/threadActivity.ts |
Adds Thinking rows and improved work-row presentation. |
apps/mobile/src/lib/threadActivity.test.ts |
Covers feed presentation behavior. |
apps/mobile/src/features/threads/ThreadFeed.tsx |
Renders Thinking rows and passes fade colors. |
apps/mobile/src/features/threads/thread-work-log.tsx |
Fixes expansion sizing and edge fades. |
apps/mobile/src/features/threads/floating-working-control.tsx |
Corrects working-pill spacing. |
apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.ts |
Resumes highlighting after long lines. |
apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.test.ts |
Tests long-line highlighting behavior. |
apps/mobile/src/components/AppSymbol.tsx |
Adds Android brain-icon fallback. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git apply --checkagainst this fork):Testing
pnpm --filter @t3tools/mobile typecheckcleanpnpm --filter @t3tools/mobile test: 155 files, 1379 tests passedpnpm lint: warnings only, no errorsAPP_VARIANT=preview npx expo export --platform ios: bundles clean (18MB .hbc)pnpm fmt:checkfailure inperf-improvements.htmluntouched by this branch.