Skip to content

Conversation

@juntyr
Copy link
Member

@juntyr juntyr commented Aug 26, 2025

Fixes #579

  • I've included my change in CHANGELOG.md

@juntyr juntyr merged commit 1dcc70e into master Aug 26, 2025
12 checks passed
@juntyr juntyr deleted the hack-patch branch August 26, 2025 20:55
@github-actions
Copy link

Benchmark for d504bc9

Click to view benchmark
Test Base PR %
"corpus/arbitrary/0a479862e1b0139f7903258e1eb1cf7192886b13" 1630.5±19.44ns 1633.7±29.14ns +0.20%
"corpus/arbitrary/0dbccb4176e49a08aa4e13730403788e45c30fc5" 5.4±0.09µs 5.5±0.14µs +1.85%
"corpus/arbitrary/109538e34607f9c81c961d2259db8de9e457b3b7" 61.4±0.91µs 59.9±1.18µs -2.44%
"corpus/arbitrary/131f2c60b6afd394bc45b7cca75560df3d418b88" 1311.6±24.53ns 1334.1±13.97ns +1.72%
"corpus/arbitrary/16173a5895eb04e696aa936ffd8603787f0c5e8f" 1536.4±32.91µs 1541.3±31.97µs +0.32%
"corpus/arbitrary/16c33ca13ee1e961d54c942192c218aa81d0a573" 6.0±0.09µs 5.8±0.08µs -3.33%
"corpus/arbitrary/18cfca6853e6c9ea7e89b2861b6765bf59e34a16" 3.5±0.07µs 3.5±0.04µs 0.00%
"corpus/arbitrary/1ad7ab43134e7eeaaa6a436cde50640a34e3a7b8" 47.8±0.76µs 47.9±0.85µs +0.21%
"corpus/arbitrary/1bed92e14abca74f7552054f759c04b8a00aac6b" 16.5±0.33µs 16.4±0.27µs -0.61%
"corpus/arbitrary/1cabd93fc9ba1be7fe4058c86a31d0acf5e4343c" 629.3±6.45µs 644.0±13.51µs +2.34%
"corpus/arbitrary/1e3acb6c0beee6c7afe8a0a784b97fa27d6e6c96" 3.7±0.09µs 3.7±0.07µs 0.00%
"corpus/arbitrary/1f77dfbc3ea85015dfdc922f4581a8fa3d2da95e" 1095.4±15.86µs 1077.2±31.28µs -1.66%
"corpus/arbitrary/2163b33994b5a9ca7936b1086fbac407ec2049f2" 15.2±0.49µs 15.3±0.41µs +0.66%
"corpus/arbitrary/220924bf261f45bf0ce4b6ab4927caa8bc85cb61" 11.3±0.21µs 11.5±0.19µs +1.77%
"corpus/arbitrary/255dd7f8c00c526a317b26173eb2a0bc50d9c4c0" 44.5±0.66µs 43.7±0.64µs -1.80%
"corpus/arbitrary/265e0e24dd30b96cfdf347874ed10a1474b61d06" 30.5±0.48µs 31.4±0.45µs +2.95%
"corpus/arbitrary/28669c94e2d8ab8330ff0b08f8f0fde5ca65a756" 49.6±0.76µs 49.2±0.85µs -0.81%
"corpus/arbitrary/291ad1cc297ecc86050becc399fea82569210914" 1649.8±21.16µs 1697.9±30.93µs +2.92%
"corpus/arbitrary/2d20eed38426c5d28a2db1a22b2db189960659b4" 12.9±0.20µs 13.4±0.21µs +3.88%
"corpus/arbitrary/309a154436204a0e974fb7991b19c6db1f21926d" 5.7±0.07µs 5.7±0.11µs 0.00%
"corpus/arbitrary/311cd6484ba04e7ffa30032efd6156d7e5f1b8cf" 5.9±0.08µs 6.0±0.12µs +1.69%
"corpus/arbitrary/313e44b279aea856c2714480f96a23936d5f3afa" 3.0±0.05µs 3.0±0.05µs 0.00%
"corpus/arbitrary/352ce75c56f12c47390495d8ef8be72d305fca08" 18.6±0.26µs 19.1±0.30µs +2.69%
"corpus/arbitrary/3beb415659360f46e82174992b6fbfb5c7c4f0ac" 4.2±0.08µs 4.3±0.07µs +2.38%
"corpus/arbitrary/3ee352b0d33b86c8dddb06cd44b50e80e28dc245" 22.5±0.39µs 22.3±0.31µs -0.89%
"corpus/arbitrary/3fbdbfa19c1f7fe6b04dba0c05566d9dc3b2107d" 2.7±0.04µs 2.7±0.07µs 0.00%
"corpus/arbitrary/485b83465b404be696e01f41999aa78ba83ba772" 13.1±0.27µs 12.8±0.23µs -2.29%
"corpus/arbitrary/4fd76408a08a700389a5dcae051eb287dfb8d156" 16.2±0.11µs 16.0±0.38µs -1.23%
"corpus/arbitrary/51ae6018d29ee3e1a5137b624be009376f781888" 15.8±0.13µs 15.6±0.32µs -1.27%
"corpus/arbitrary/5382e7432477446daa095bc3e1b76f3c7de22b5a" 8.7±0.22µs 8.8±0.60µs +1.15%
"corpus/arbitrary/54c21178a3a88a160e6ca4124fa78240c3cfba24" 1204.4±22.29µs 1203.9±28.45µs -0.04%
"corpus/arbitrary/58410025c28776618491612d9b0041bb0082a5b1" 8.6±0.13µs 8.6±0.12µs 0.00%
"corpus/arbitrary/5999f6ecf44196fe8b5cf8569d1c48f215ed1c65" 5.4±0.08µs 5.7±0.71µs +5.56%
"corpus/arbitrary/62f152cfaff0984dca7cb4c2cedb3a26b5b7897d" 3.9±0.08µs 3.9±0.10µs 0.00%
"corpus/arbitrary/6b0c7aba6d49715409c864066f5bad2ac4b7a154" 20.1±0.16µs 20.2±0.35µs +0.50%
"corpus/arbitrary/6c9c6e0d38ea4fa687bc3f8863849d01fd4e1f6f" 2.4±0.04µs 2.3±0.04µs -4.17%
"corpus/arbitrary/6d81eae4886b87f787666749bd0221ceb7488f53" 2.7±0.04µs 2.7±0.04µs 0.00%
"corpus/arbitrary/70a43dd6f4d5deb0be22418c81a51de11264b990" 52.2±1.64µs 53.5±1.23µs +2.49%
"corpus/arbitrary/716ed30482b11b3a3885498b3aa2e7b854b56755" 3.5±0.03µs 3.5±0.04µs 0.00%
"corpus/arbitrary/737f105a33a3b1ff8be826576290ea30731da025" 3.1±0.05µs 3.3±0.05µs +6.45%
"corpus/arbitrary/7396c84c155a72efd790b2ebbe957a6be1b2660c" 5.0±0.05µs 5.0±0.12µs 0.00%
"corpus/arbitrary/73a216dc88c46579ea8ee91ceaecdd874e5b2d81" 13.7±0.38µs 13.9±0.25µs +1.46%
"corpus/arbitrary/75e1089482114665bfe25d0727650cf22be87f2f" 9.9±0.15µs 9.9±0.15µs 0.00%
"corpus/arbitrary/76597ffa38ab5bcbae55210079d974532ae5ab72" 5.1±0.07µs 5.0±0.08µs -1.96%
"corpus/arbitrary/76decaac556d14f589924ff9022480bcc592c955" 6.6±0.12µs 6.5±0.05µs -1.52%
"corpus/arbitrary/79ebb925acd82512b6366b28a7b8fea1b25edafb" 4.5±0.04µs 4.5±0.07µs 0.00%
"corpus/arbitrary/7c6adb9c9554d7d67c56bf26253a167fca825c55" 4.4±0.08µs 4.5±0.07µs +2.27%
"corpus/arbitrary/82c625dae82ffb35dc25cd8f5b432af3e30a4825" 12.8±0.58µs 12.5±0.20µs -2.34%
"corpus/arbitrary/83af2bbc9cf6b247c9ba8f81e33e1af0d28c6348" 30.4±0.52µs 31.2±0.81µs +2.63%
"corpus/arbitrary/855ad5c047760710abef21ab421f2947fa8a2c94" 6.3±0.19µs 6.3±0.21µs 0.00%
"corpus/arbitrary/858e63afd9cfccf84283007cf6e28ad7a8ba7298" 2.2±0.03µs 2.1±0.02µs -4.55%
"corpus/arbitrary/85fc3a7886ceed42d0b9a81834e95b613cefa68f" 2.7±0.02µs 2.6±0.05µs -3.70%
"corpus/arbitrary/87ec01b6dfb5b98a08e1f289680506e4f1406f50" 42.9±0.67µs 42.8±0.72µs -0.23%
"corpus/arbitrary/8a2e97e890bdbb6dfb074b84a76048c1b770f46b" 4.4±0.06µs 4.3±0.03µs -2.27%
"corpus/arbitrary/9263cad652aabf8f45f588adb3bf37e3062c5300" 3.7±0.07µs 3.8±0.06µs +2.70%
"corpus/arbitrary/94d48e6ba8758dfacb984005d93fb6bba53704f6" 21.6±0.33µs 21.9±0.32µs +1.39%
"corpus/arbitrary/98dfcc133eb2a838f6cba965c0956ae8e003259a" 5.4±0.26µs 5.4±0.11µs 0.00%
"corpus/arbitrary/9ad089474eb754e218e2e6825c8c2d0993859801" 136.4±2.17µs 135.8±1.52µs -0.44%
"corpus/arbitrary/a157882180762d49c35cc44c3090b2ce7affcd4e" 2.7±0.02µs 2.7±0.05µs 0.00%
"corpus/arbitrary/a3d5b87fd497d1ef4689ec0c3809d4aa2b97f39c" 2.6±0.08µs 2.6±0.03µs 0.00%
"corpus/arbitrary/a6fe071f166f34dfdba6d92b93fe875c86e1037a" 10.1±0.07µs 10.2±0.16µs +0.99%
"corpus/arbitrary/a87dd42a7cfff33e61eebe0f470a46b29dde5a12" 4.1±0.06µs 4.1±0.05µs 0.00%
"corpus/arbitrary/aa26a49156602060050707e2bd7f310c84f6bda2" 38.2±0.91µs 37.9±0.73µs -0.79%
"corpus/arbitrary/ade46d679109fe1d0fb0edfc9fa9c5d2937ba01f" 9.4±0.09µs 9.3±0.14µs -1.06%
"corpus/arbitrary/b40893bae2d3890a3e425f3beeaf3aacac8117af" 5.1±0.08µs 5.2±0.11µs +1.96%
"corpus/arbitrary/b69f7d35055f6f1727001680549d7a1748e9b794" 2.5±0.02µs 2.8±0.04µs +12.00%
"corpus/arbitrary/bee3e699a4e707a6370f239d6e7d9aa119d0bfbf" 77.2±1.93µs 76.0±0.72µs -1.55%
"corpus/arbitrary/c174d931b22eb8c29291a0621b0d55239f7c7832" 5.8±0.08µs 5.8±0.11µs 0.00%
"corpus/arbitrary/c218c4485342a15acb4a52f22ea03c2603fea327" 4.6±0.08µs 4.6±0.08µs 0.00%
"corpus/arbitrary/c7de02a9db732a9620fdcf3d662444cb59a55d72" 24.4±0.46µs 24.8±0.53µs +1.64%
"corpus/arbitrary/cd5f1a2c06a589c26b1386003fdc8fda4a20bac2" 14.9±0.32µs 15.1±0.24µs +1.34%
"corpus/arbitrary/cdd5e897acce73c9e44a829e8bdd84110b3231af" 96.0±2.23µs 92.9±1.24µs -3.23%
"corpus/arbitrary/ce0f099f709896f344689cff150224d87627eeed" 9.6±0.18µs 9.6±0.22µs 0.00%
"corpus/arbitrary/cf98a909ccda45a5c0d262ea4d8b269c8c62577f" 352.3±7.29µs 349.9±6.82µs -0.68%
"corpus/arbitrary/d06b690498215e82c96aaefe215565e11caec40c" 32.0±2.02µs 31.5±0.60µs -1.56%
"corpus/arbitrary/d174ea7f4b550b05b63c54907847e7522b2ee988" 6.4±0.11µs 6.2±0.11µs -3.13%
"corpus/arbitrary/d40d4618e79e43f7c5247fbbbb4f723b218997ba" 3.9±0.03ms 3.8±0.04ms -2.56%
"corpus/arbitrary/d5b94f4496f5417a1a3fd4ac9a4d8089e373eefa" 5.5±0.07µs 5.7±0.17µs +3.64%
"corpus/arbitrary/d6bd21b753f831c14827a0445019dd7c36ec00cd" 10.1±0.16µs 10.2±0.19µs +0.99%
"corpus/arbitrary/d73fab82bb2664396f37b55e436af2dee5028949" 20.6±0.41µs 20.7±1.39µs +0.49%
"corpus/arbitrary/d7d0867284c24f50f9ea0147207196377d3ea791" 9.2±0.14µs 9.3±0.18µs +1.09%
"corpus/arbitrary/da3e36cbb193017c59afbc3f058b1b23e0811884" 240.3±1.62ms 234.8±2.36ms -2.29%
"corpus/arbitrary/daf0b2dcedfd97148ac57421692db09252a0419b" 3.9±0.04µs 4.0±0.03µs +2.56%
"corpus/arbitrary/dfb15fe9db07d367690937f2716730d7396ce7b3" 89.7±1.82µs 90.7±2.13µs +1.11%
"corpus/arbitrary/e05833b3f3fe6e87ae18163a923c3fbdc20d01a8" 47.2±1.14µs 45.9±0.97µs -2.75%
"corpus/arbitrary/e0865a79acc69e49e83204a5e1ef50a87cddc06d" 93.9±10.40µs 95.0±1.72µs +1.17%
"corpus/arbitrary/e1bc8f6f7b8fab7030ca293363133f023b94640a" 1343.8±32.86ns 1302.0±23.68ns -3.11%
"corpus/arbitrary/e58c2b7570775804c3fd9f26f33d9e32e96c235a" 5.1±0.06µs 5.2±0.10µs +1.96%
"corpus/arbitrary/eb83585674c5aa56b951706588e99c26c05d99d2" 26.7±0.41µs 25.9±0.43µs -3.00%
"corpus/arbitrary/ed4c83134f092552bd6e2ac451a9c13f30510cb4" 17.8±0.18µs 18.3±0.43µs +2.81%
"corpus/arbitrary/ee84ae4ecb693ca1c9b57d97cea4be5c94364d0e" 2.8±0.04µs 2.8±0.04µs 0.00%
"corpus/arbitrary/f1385a6979ae6cd284e2f9e8afce6b3e6f3a7f5d" 5.2±0.06µs 5.2±0.08µs 0.00%
"corpus/arbitrary/f470a27d9e257f03b0a2ddbbe558b7fa66363e25" 9.3±0.13µs 9.1±0.14µs -2.15%
"corpus/arbitrary/f4a13f16264f8157ca1d46910a4bd167987b25db" 219.6±1.81µs 216.8±2.36µs -1.28%
"corpus/arbitrary/f597baaaa33da775a472b022269263fa0e3641e1" 5.5±0.41µs 5.8±0.09µs +5.45%
"corpus/arbitrary/f9e94560733a3e2b9a24da6eb70de419a8c1bfa6" 730.1±7.27ns 712.3±12.57ns -2.44%
"corpus/arbitrary/fb4dedac9d5ad7d7c77c24b7e4e2e9201f521321" 97.4±1.33µs 96.1±0.79µs -1.33%
"corpus/arbitrary/fc72ed5725d1c04ec5b40ede6e56b2d9297b5841" 8.2±0.14µs 8.4±0.20µs +2.44%
"corpus/arbitrary/fe62c753c40e656689ac4efd89b13938ca904622" 6.9±0.12µs 6.9±0.12µs 0.00%
"corpus/arbitrary/fefdba0c505e2f1e097224ab424784f0bb0e585b" 139.1±1.83µs 136.7±3.97µs -1.73%

@konstin
Copy link

konstin commented Aug 27, 2025

Could I ask for a new release with this patch? Without this change, our downstream CI is broken (pubgrub-rs/pubgrub#350).

@juntyr
Copy link
Member Author

juntyr commented Aug 27, 2025

Could I ask for a new release with this patch? Without this change, our downstream CI is broken (pubgrub-rs/pubgrub#350).

I've just published ron v0.11.0 :)

@konstin
Copy link

konstin commented Aug 27, 2025

Thank you!

konstin added a commit to astral-sh/pubgrub that referenced this pull request Aug 27, 2025
github-merge-queue bot pushed a commit to pubgrub-rs/pubgrub that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserializing internally-tagged enums fails on nightly Rust

3 participants