Skip to content

Allow writing to io::Writer#562

Merged
juntyr merged 2 commits intoron-rs:masterfrom
juntyr:io-write
Mar 19, 2025
Merged

Allow writing to io::Writer#562
juntyr merged 2 commits intoron-rs:masterfrom
juntyr:io-write

Conversation

@juntyr
Copy link
Member

@juntyr juntyr commented Mar 19, 2025

Fixes #561

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Mar 19, 2025

@Ummon Would this fix your issue?

@Ummon
Copy link

Ummon commented Mar 19, 2025

@Ummon Would this fix your issue?

Yep, it seems fine, thank you.

@juntyr juntyr merged commit 8350604 into ron-rs:master Mar 19, 2025
13 checks passed
@juntyr juntyr deleted the io-write branch March 19, 2025 08:56
@juntyr
Copy link
Member Author

juntyr commented Mar 19, 2025

@Ummon I'll wait until ~the end of the day to see if any other issues come up that can be included in a small v0.9.1 release

@jonaspleyer
Copy link

jonaspleyer commented Mar 24, 2025

@Ummon I'll wait until ~the end of the day to see if any other issues come up that can be included in a small v0.9.1 release

Thanks for working on this. I really appreciate the backwards compatibility. I was already about to construct a workaround when I discovered this issue. I have tried the patch with

[patch.cartes-io]
ron = { git = "https://github.com/ron-rs/ron/" }

and all my tests passed.

@jonaspleyer
Copy link

@Ummon I'll wait until ~the end of the day to see if any other issues come up that can be included in a small v0.9.1 release

Hey @juntyr I would really appreciate a 0.9.1 release with this patch included. Thanks.

@juntyr
Copy link
Member Author

juntyr commented Apr 8, 2025

@Ummon I'll wait until ~the end of the day to see if any other issues come up that can be included in a small v0.9.1 release

Hey @juntyr I would really appreciate a 0.9.1 release with this patch included. Thanks.

I'm really sorry for the delay, I just published v0.10.1 (mostly the same as v0.9.0 unless you matched on v0.9.0's new Number type).

@jonaspleyer
Copy link

Thanks so much for the quick response! And no worries about the delay 👍 😄

@torokati44
Copy link

What about the methods in ron::ser, outside of Options? 😶

@juntyr
Copy link
Member Author

juntyr commented Apr 26, 2025

What about the methods in ron::ser, outside of Options? 😶

The methods in ron::ser are meant to be a small set of convenience helpers. If you want a particular helper to be added, you can always open a PR. But at least from my end most new functionality will be for the Options since they are more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.9 changes prevent to use a std::fs::File directly with to_writer and to_writer_pretty

4 participants