[ROMM-1427] Add option to remove game from continue playing #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamantike
reviewed
Jan 10, 2025
| }) | ||
| .then(() => { | ||
| emitter?.emit("snackbarShow", { | ||
| msg: `${props.rom.name} removed from Continue Playing`, |
There was a problem hiding this comment.
Do we currently support i18n here?
There was a problem hiding this comment.
Yes, but we already have a ton of these error messages that aren't translated. At some point we'll do a second pass and correct these, but since they're transient IMO they're lower priority.
zurdi15
requested changes
Jan 10, 2025
Co-authored-by: Zurdi <[email protected]>
zurdi15
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply sets
last_playingtonull, since it doesn't make a ton of sense to add more complexity for a field that'll just be overwritten next play IMO. Other solutions would require adding more fields or local storage, and that's too much work lol.