fix: add param from_queryset to refresh_from_db
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
django updated their signature for `refresh_from_db` to include this param, so the library fails on django 5.1 link to django release note: https://docs.djangoproject.com/en/5.1/releases/5.1/ link to django source where it changed: django/django@f92641a
this is kinda hacky, but I cannot think of a better way to do this. I could use inspect to check if `from_queryset` param exists for `refresh_from_db` method, but I believe that is an overkill here.
ayys
force-pushed
the
develop
branch
2 times, most recently
from
fa646be to
e331508
Compare
|
pinging @romgar for review :) |
this is done to leave transparently pass through all the arguments to django. Makes the function more resiliant against future changes to django's API.
|
@romgar I fixed the comments, and added a regression test. idk how to write a proper test for this case though, thoughts? |
tests/test_core.py
Outdated
| @@ -214,6 +214,23 @@ def test_refresh_from_db_no_fields(): | |||
| assert tm.get_dirty_fields() == {"boolean": True, "characters": "old value"} | |||
|
|
|||
|
|
|||
| @pytest.mark.django_db | |||
| def test_refresh_from_db_with_from_queryset(): | |||
| """Tests passthrough of `save_queryset` field in refresh_from_db | |||
There was a problem hiding this comment.
save_queryset -> from_queryset typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django updated their signature for
refresh_from_dbto include this param, so the library fails on django 5.1link to django release note:
https://docs.djangoproject.com/en/5.1/releases/5.1/
link to django source where it changed:
django/django@f92641a