Use RSS v2 parser by default #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,16 +50,10 @@ protected Description parseItemDescription(final Element rssRoot, final Element | |||
|
|
|||
| @Override | |||
| public boolean isMyType(final Document document) { | |||
| return rootElementMatches(document) && versionMatches(document); | |||
| return rootElementMatches(document); | |||
There was a problem hiding this comment.
This will only work as long as the RSS 2.0 parser is the last RSS parser that will be checked. As far as I know this is depending on the order in rome.properties. I would propose to check whether the version matches (like before) or whether the version is null.
Changed RSS v2 parser to match any feed that has "rss" as root element. This makes Rome more lenient when handling feeds that don't adhere to the RSS spec, namely have the "version" attribute missing.
PatrickGotthard
added a commit
that referenced
this pull request
Mar 1, 2016
Use RSS2 parser as fallback when no version is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed RSS v2 parser to match any feed that has "rss" as root element.
This makes Rome more lenient when handling feeds that don't adhere to
the RSS spec, namely have the "version" attribute missing.
Fixes #186