This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_service): add parser option for unsafe decorators #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
denbezrukov
reviewed
Jun 15, 2023
| pub jsx_quote_style: Option<QuoteStyle>, | ||
| /// When properties in objects are quoted. Defaults to asNeeded. | ||
| #[bpaf(long("quote-properties"), argument("preserve|as-needed"), optional)] | ||
| #[serde(skip_serializing_if = "Option::is_none")] |
There was a problem hiding this comment.
How does it work without skip_serializing_if? Does it use default value?
There was a problem hiding this comment.
Yes, which is not ideal. Still, we don't use the serialization feature, but when we will, that's exactly what will happen.
denbezrukov
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4573
Test Plan
I will add tests in the next PRs
Changelog
Documentation