This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): useDefaultParameterLast
#3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
reviewed
Nov 28, 2022
crates/rome_js_analyze/src/analyzers/nursery/use_default_function_parameter_last.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/nursery/useDefaultFunctionParameterLast/invalid.js
Outdated
Show resolved
Hide resolved
Conaclos
changed the title
useDefaultFunctionParameterLast
ematipico
reviewed
Nov 29, 2022
crates/rome_js_analyze/src/analyzers/nursery/use_default_function_parameter_last.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/tests/specs/nursery/useDefaultFunctionParameterLast/invalid.js
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/use_default_function_parameter_last.rs
Outdated
Show resolved
Hide resolved
Conaclos
requested review from
ematipico
and removed request for
xunilrj and
leops
ematipico
approved these changes
Nov 30, 2022
crates/rome_js_analyze/tests/specs/nursery/useDefaultFunctionParameterLast/invalid.ts.snap
Outdated
Show resolved
Hide resolved
MichaReiser
approved these changes
Dec 5, 2022
|
Due to the decision of leops, I will rename the rule to |
Thanks for this comment. I was just about to merge in |
MichaReiser
changed the title
useDefaultFunctionParameterLastuseDefaultParameterLast
|
@MichaReiser Renamed and rebased :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements ESLint's default-param-last under the name
useDefaultParameterLast.Test Plan
Unit tests and doc-tests included.