fix(semantic_analyzers): style/noShoutyConstants does not recognize multiple uses of a constant.

crates/rome_js_analyze/src/semantic_analyzers/style/no_shouty_constants.rs

@@ -5,7 +5,7 @@ use rome_diagnostics::Applicability;
 use rome_js_semantic::{AllReferencesExtensions, Reference};
 use rome_js_syntax::{
     JsAnyExpression, JsAnyLiteralExpression, JsIdentifierBinding, JsIdentifierExpression,
-    JsStringLiteralExpression, JsVariableDeclaration, JsVariableDeclarator,
+    JsReferenceIdentifier, JsStringLiteralExpression, JsVariableDeclaration, JsVariableDeclarator,
     JsVariableDeclaratorList,
 };
 use rome_rowan::{AstNode, BatchMutationExt, SyntaxNodeCast};
@@ -101,6 +101,9 @@ impl Rule for NoShoutyConstants {
                     return None;
                 }
 
+                if binding.all_references(ctx.model()).count() > 1 {
+                    return None;
+                }
                 return Some(State {
                     literal,
                     references: binding.all_references(ctx.model()).collect(),

crates/rome_js_analyze/tests/specs/style/noShoutyConstants.js

@@ -6,6 +6,13 @@ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
 console.log(FOO, FOO4);
 
 let foo = "foo";
+const B = "B";
+export default B;
+export const A = "A";
 
-const A = "A";
-export default A;
+const BAR = "BAR";
+
+export const bar = {
+	foo: BAR,
+	bar: BAR,
+};

crates/rome_js_analyze/tests/specs/style/noShoutyConstants.js.snap

@@ -1,5 +1,6 @@
 ---
 source: crates/rome_js_analyze/tests/spec_tests.rs
+assertion_line: 73
 expression: noShoutyConstants.js
 ---
 # Input
@@ -12,60 +13,19 @@ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
 console.log(FOO, FOO4);
 
 let foo = "foo";
+const B = "B";
+export default B;
+export const A = "A";
 
-const A = "A";
-export default A;
-```
-
-# Diagnostics
-```
-noShoutyConstants.js:1:7 lint/style/noShoutyConstants  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-
-  ! Redundant constant declaration.
-
-  > 1 │ const FOO = "FOO";
-      │       ^^^^^^^^^^^
-    2 │ console.log(FOO, FOO2);
-    3 │ 
-
-  i Used here.
-
-    1 │ const FOO = "FOO";
-  > 2 │ console.log(FOO, FOO2);
-      │             ^^^
-    3 │ 
-    4 │ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
-
-  i Used here.
-
-    4 │ const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
-    5 │ 
-  > 6 │ console.log(FOO, FOO4);
-      │             ^^^
-    7 │ 
-    8 │ let foo = "foo";
-
-  i You should avoid declaring constants with a string that's the same
-        value as the variable name. It introduces a level of unnecessary
-        indirection when it's only two additional characters to inline.
-
-  i Suggested fix: Use the constant value directly
-
-     1    │ - const·FOO·=·"FOO";
-     2    │ - console.log(FOO,·FOO2);
-        1 │ + 
-        2 │ + console.log("FOO",·FOO2);
-     3  3 │   
-     4  4 │   const FOO2 = "FOO2", a = "FOO3", FOO4 = "FOO4";
-     5  5 │   
-     6    │ - console.log(FOO,·FOO4);
-        6 │ + console.log("FOO",·FOO4);
-     7  7 │   
-     8  8 │   let foo = "foo";
-
+const BAR = "BAR";
 
+export const bar = {
+	foo: BAR,
+	bar: BAR,
+};
 ```
 
+# Diagnostics
 ```
 noShoutyConstants.js:4:7 lint/style/noShoutyConstants  FIXABLE  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━