This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
doc(website): Add context about Romes philosophy #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #3698 (reply in thread) if you are new to the world of formatting it might be hard to understand at first why Rome (and Prettier) are so opinionated. Prettier has a whole philosophy page which might be overkill at this point. But adding just a few of these links add's a lot of necessary context as they will either immediately resonate or alienate people which are looking for a less opinionated tool.
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
approved these changes
Nov 14, 2022
|
Thank you! |
MichaReiser
changed the title
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 14, 2022
* upstream/main: (45 commits) website(docs): set `color-scheme` on the root element (rome#3721) feat(rome_analyze): add a warning for unused suppression comments (rome#3718) feat(rome_js_analyze): Implement prefer-numeric-literals lint (rome#3558) feat(rome_js_formatter): jestEach template literals rome#3308 (rome#3582) doc(website): Add context about Romes philosophy (rome#3714) fix(rome_js_formatter): Single-line comment below a JSX prop triggers… (rome#3641) test(rome_js_formatter): update prettier tests (rome#3684) fix(rome_js_parser): improve await handling in non-async context (rome#3573) fix(rome_js_parser): improve yield parsing in non generator function (rome#3622) More playground polish Fix backgrounds Fix height Align docs.rome.tools with rome.tools Reenable compression Add missing width website(docs): More playground IDE features (rome#3711) fix(rome_js_formatter): new expression attribute (rome#3686) docs(website): added checkbox to toggle linter in playground (rome#3699) website(docs): More website tweaks (rome#3707) website(docs): Add default layout property (rome#3705) ...
|
Thanks for merging and thanks for taking the time to explain where this decision came from as well :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #3698 (reply in thread) if you are new to the world of formatting it might be hard to understand at first why Rome (and Prettier) are so opinionated. Prettier has a whole philosophy page which might be overkill at this point. But adding just a few of these links add's a lot of necessary context as they will either immediately resonate or alienate people which are looking for a less opinionated tool.