This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): False positives for interactive elements in useKeyWithClickEvents
#3644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactive elements like
button
,a
,input
etc. don't need key events as they are supported by the browser.This is a simplified implementation and the rule should also consider if the element is hidden for screen readers but that's out of the scope of this fix. See #3640
Test Plan
I added a new test that verifies that
button
no longer gets flagged.Versioning
This reduces the number of lint warnings and is thus, safe to land