This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): fix the debug bound checks of the CFG visitor #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
ematipico
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3390
The
NodeVisitorimplementation used to build the Control Flow Graph has some additional checks in debug mode to ensure the CFG builder for a given function does not access any state belonging to another function, but offsets in the visitor state stack were not properly calculated to account for this leading to panics when break or continue statements needed to access said stack.Test Plan
I added an additional test case that could reliably reproduce the panic before the fix, and no longer does with the changes applied.