This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_parser): Allow arguments in d.ts files
#3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
1 task
MichaReiser
force-pushed
the
fix/arguments-ambient-context
branch
from
e9ab694 to
92b39d7
Compare
Ambient context has slightly different rules than parsing in a normal context. One such difference is that `arguments` and future reserved keywords are valid identifiers. Our parser already correctly handled this case by setting the `strict_mode` to `None` when entering an ambient context. However, we initialized `strict_mode` with `Module` for `d.ts` files. This PR correctly initializes the parser state with `strict = None` if the file is a type script definition file. ## Tests I added a new parser test and verified that the `jquery.d.ts` can now be formatted ```bash cargo run --bin rome format ../vscode/extensions/html-language-features/server/lib/jquery.d.ts --write ```
MichaReiser
force-pushed
the
fix/arguments-ambient-context
branch
from
92b39d7 to
882d593
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
ematipico
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ambient context has slightly different rules than parsing in a normal context. One such difference is that
argumentsand future reserved keywords are valid identifiers.Our parser already correctly handled this case by setting the
strict_modetoNonewhen entering an ambient context. However, we initializedstrict_modewithModuleford.tsfiles.This PR correctly initializes the parser state with
strict = Noneif the file is a type script definition file.Tests
I added a new parser test and verified that the
jquery.d.tscan now be formatted