This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_cli): correctly compute configuration #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ematipico
force-pushed
the
fix/fix-argument-not-picked
branch
from
1bd44ca
to
ce66ebd
Compare
ematipico
changed the title
MichaReiser
reviewed
Sep 7, 2022
| } | ||
| apply_format_settings_from_cli(&mut session, &mut workspace_settings)?; | ||
| let configuration = apply_format_settings_from_cli(&mut session, configuration)?; | ||
| session |
There was a problem hiding this comment.
What does this change mean for concurrent usages of the deamon. Do the CLI argument change for all requests to the workspace?
There was a problem hiding this comment.
Not sure want you mean. We only update the settings once (request), then each format_file request (for example) reads those settings anytime they need.
There was a problem hiding this comment.
Yes, but what if multiple clients are connected to the same daemon
# client 1
rome format --indent-style="tab" --use-server
#client 2
rome format --indent-style="space" --use-serverAnd both commands run at the same time. Which configuration would be used?
There was a problem hiding this comment.
Both clients have two different instances of Workspace, so their configuration won't mix up.
leops
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3175
We were incorrectly computing a
WorkspaceSettings, while now we should change/create aConfigurationstruct instead and then update the settings of the workspace.This bug went undetected because we don't have tests that check that arguments passed via CLI are correctly applied.
Test Plan
I created two new tests, one that applies the generic configuration of the formatter and one that applies the configuration for the javascript language.