This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): Skipped token trivia spacing #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rometools canceled.
|
The formatting of `JsxExpressionAttributeValue` used to special handle the case when the `}` token has a skipped token trivia attached.
```javascript
<div className={asdf asdf} />
```
The special handling ensured that the formatter inserts a whitespace between the expression and the skipped token trivia so that the above doesn't become
```javascript
<div className={asdfasdf} />
```
The problem with the old solution is that it doesn't scale. We can't add these checks in every place where some skipped token trivia may be possibler (which, could be any node).
This PR improves the skipped token trivia formatting in rome formatter to account for any trailing whitespace of the previous token and preserves if it is followed by a skipped token trivia.
## Tests
Verified that the test is still passing after removing the special handling in the attribute formatting.
https://github.com/rome/tools/blob/c6d0450c06e7bd357a3a30fab161c5537448fadc/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap#L54-L56
MichaReiser
force-pushed
the
fix/skipped-token-trivia-spacing
branch
from
122a1d5
to
ac22cd6
Compare
Deploying with
|
| Latest commit: |
ac22cd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3726529.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-skipped-token-trivia-spa.tools-8rn.pages.dev |
ematipico
approved these changes
Sep 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting of
JsxExpressionAttributeValueused to special handle the case when the}token has a skipped token trivia attached.The special handling ensured that the formatter inserts a whitespace between the expression and the skipped token trivia so that the above doesn't become
The problem with the old solution is that it doesn't scale. We can't add these checks in every place where some skipped token trivia may be possibler (which, could be any node).
This PR improves the skipped token trivia formatting in rome formatter to account for any trailing whitespace of the previous token and preserves if it is followed by a skipped token trivia.
Tests
Verified that the test is still passing after removing the special handling in the attribute formatting.
tools/crates/rome_js_formatter/tests/specs/jsx/attributes.jsx.snap
Lines 54 to 56 in c6d0450