Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): false positive useShorthandArrayTypes #3119

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix(rome_js_analyze): false positive useShorthandArrayTypes #3119

merged 2 commits into from
Sep 2, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 1, 2022 •
edited
Loading

✅ Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 99f7cee
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/63109b6ae5f8e60009cb98f3

@IWANABETHATGUY IWANABETHATGUY force-pushed the fix/false-positive-use-shorthand-array-types branch from 83be2eb to 99f7cee Compare September 1, 2022 11:45
@IWANABETHATGUY
Copy link
Contributor Author

All the behavior has been aligned to rome classic

@IWANABETHATGUY
Copy link
Contributor Author

@leops , @xunilrj Would you mind helping with review this pull request?

@ematipico
Copy link
Contributor

@leops @xunilrj please merge once you're OK

@leops leops merged commit a1a5cd3 into rome:main Sep 2, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the fix/false-positive-use-shorthand-array-types branch September 2, 2022 07:08
ematipico pushed a commit that referenced this pull request Sep 5, 2022
@IWANABETHATGUY @ematipico
fix(rome_js_analyze): false positive useShorthandArrayTypes (#3119)
6ff35c9 
* feat: 🎸 finsish

* fix: 🐛 cr issues
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichaReiser MichaReiser MichaReiser left review comments

@ematipico ematipico ematipico approved these changes

@leops leops leops approved these changes

@xunilrj xunilrj Awaiting requested review from xunilrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 ts/useShorthandArrayType is not taking into consideration the need for parenthesis
4 participants
@IWANABETHATGUY @ematipico @MichaReiser @leops