fix(rome_js_parser): Adding syntax error for new A?.b()

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts

@@ -147,6 +147,6 @@ if ((this ?? {}).#bar) { foo.bar; }
 
 (undefined && this ?? {}).#bar;
 (((typeof this) as string) || {}).#bar;
-(new foo || {}).bar;
+// (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 (foo() || {}).bar;
 ((foo || {}).bar() || {}).baz;

crates/rome_js_analyze/tests/specs/nursery/useOptionalChain/nullishAndLogicalOr.ts.snap

@@ -153,7 +153,7 @@ if ((this ?? {}).#bar) { foo.bar; }
 
 (undefined && this ?? {}).#bar;
 (((typeof this) as string) || {}).#bar;
-(new foo || {}).bar;
+// (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 (foo() || {}).bar;
 ((foo || {}).bar() || {}).baz;
 
@@ -2437,7 +2437,7 @@ Suggested fix: Change to an optional chain.
 147     | - (undefined && this ?? {}).#bar;
     147 | + (undefined && this)?.#bar;
 148 148 |   (((typeof this) as string) || {}).#bar;
-149 149 |   (new foo || {}).bar;
+149 149 |   // (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 150 150 |   (foo() || {}).bar;
 
 
@@ -2457,27 +2457,7 @@ Suggested fix: Change to an optional chain.
 147 147 |   (undefined && this ?? {}).#bar;
 148     | - (((typeof this) as string) || {}).#bar;
     148 | + ((typeof this) as string)?.#bar;
-149 149 |   (new foo || {}).bar;
-150 150 |   (foo() || {}).bar;
-151 151 |   ((foo || {}).bar() || {}).baz;
-
-
-```
-
-```
-warning[nursery/useOptionalChain]: Change to an optional chain.
-    ┌─ nullishAndLogicalOr.ts:150:1
-    │
-150 │ (new foo || {}).bar;
-    │ -------------------
-
-Suggested fix: Change to an optional chain.
-        | @@ -147,6 +147,6 @@
-146 146 |   
-147 147 |   (undefined && this ?? {}).#bar;
-148 148 |   (((typeof this) as string) || {}).#bar;
-149     | - (new foo || {}).bar;
-    149 | + new foo?.bar;
+149 149 |   // (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 150 150 |   (foo() || {}).bar;
 151 151 |   ((foo || {}).bar() || {}).baz;
 
@@ -2495,7 +2475,7 @@ Suggested fix: Change to an optional chain.
         | @@ -148,5 +148,5 @@
 147 147 |   (undefined && this ?? {}).#bar;
 148 148 |   (((typeof this) as string) || {}).#bar;
-149 149 |   (new foo || {}).bar;
+149 149 |   // (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 150     | - (foo() || {}).bar;
     150 | + foo()?.bar;
 151 151 |   ((foo || {}).bar() || {}).baz;
@@ -2513,7 +2493,7 @@ warning[nursery/useOptionalChain]: Change to an optional chain.
 Suggested fix: Change to an optional chain.
         | @@ -149,4 +149,4 @@
 148 148 |   (((typeof this) as string) || {}).#bar;
-149 149 |   (new foo || {}).bar;
+149 149 |   // (new foo || {}).bar;  // tracked here https://github.com/rome/tools/issues/3257
 150 150 |   (foo() || {}).bar;
 151     | - ((foo || {}).bar() || {}).baz;
     151 | + foo?.bar()?.baz;

crates/rome_js_parser/src/syntax/expr.rs

@@ -768,6 +768,23 @@ fn parse_new_expr(p: &mut Parser, context: ExpressionContext) -> ParsedSyntax {
         .or_add_diagnostic(p, expected_expression)
         .map(|expr| parse_member_expression_rest(p, expr, context, false, &mut false))
     {
+        // test_err ts invalid_optional_chain_from_new_expressions
+        // new Test<string>?.test();
+        // new Test?.test();
+        // new A.b?.c()
+        // new (A.b)?.c()
+        // new (A.b?.()).c()
+        // new A.b?.()()
+        if p.at(T![?.]) {
+            let error = p
+                .err_builder("Invalid optional chain from new expression.")
+                .primary(
+                    p.cur_range(),
+                    &format!("Did you mean to call '{}()'?", lhs.text(p)),
+                );
+
+            p.error(error);
+        }
         if let TS_INSTANTIATION_EXPRESSION = lhs.kind() {
             lhs.undo_completion(p).abandon(p)
         };