🐛 noUselessFragments is inconsistent/buggy

[nstepien]

Environment information

CLI:
  Version:              10.0.1
  Color support:        true

Platform:
  CPU Architecture:     x86_64
  OS:                   windows

Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 unset

Rome Configuration:
  Status:               loaded
  Formatter disabled:   true
  Linter disabled:      false

Workspace:
  Open Documents:       0

Discovering running Rome servers...

Running Rome Server: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

i The client isn't connected to any server but rage discovered this running Rome server.

Server:
  Version:              10.0.1
  Name:                 rome_lsp
  CPU Architecture:     x86_64
  OS:                   windows

Workspace:
  Open Documents:       0

Other Active Server Workspaces:

Workspace:
  Open Documents:       6
  Client Name:          Visual Studio Code
  Client Version:       1.73.1

What happened?

Issue 1

function Component1() {
  const str = 'str';
  return <>{str}</>;
}

function Component2() {
  const str = 'str';
  return (<>{str}</>);
}

The noUselessFragments rule finds an issue in Component2, but not in Component1, the only difference is the parentheses.

Issue 2

const obj = {
  element: <>test</>
};

if I apply the rule suggestion, I end up with this:

const obj = {
  "test"
};

which is not valid JS.

  ! Avoid using unnecessary Fragment.

    176 │ const obj = {
  > 177 │   element: <>test</>
        │            ^^^^^^^^^
    178 │ };
    179 │ 

  i Suggested fix: Remove the Fragment

    175 175 │ 
    176 176 │   const obj = {
    177     │ - ··element:·<>test</>
        177 │ + ··"test"
    178 178 │   };
    179 179 │ 

Expected result

No bugs!

FWIW because of a TypeScript limitation, components cannot return a string for example, otherwise it'll lead to type issues, so some fragments must be preserved in .tsx files.

In the second example, I'm not convinced it's safe to remove the fragment there anyway, we don't know where obj.element will be used.

Code of Conduct

• I agree to follow Rome's Code of Conduct