Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Parser: Allow super in constructor parameter. #3613

Closed
1 task done
MichaReiser opened this issue Nov 9, 2022 · 1 comment · Fixed by #3678
Closed
1 task done

🐛 Parser: Allow super in constructor parameter. #3613

MichaReiser opened this issue Nov 9, 2022 · 1 comment · Fixed by #3678
Assignees
@denbezrukov
Labels
A-Parser Area: parser L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@MichaReiser
Copy link
Contributor

Environment information

Playground

What happened?

Rome emits syntax errors for the following valid program:

class A extends B {
  constructor(c = super()) {}
}

Expected result

Rome parses the program without syntax errors.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug L-JavaScript Langauge: JavaScript A-Parser Area: parser labels Nov 9, 2022
@MichaReiser MichaReiser mentioned this issue Nov 9, 2022
Closed
1 task
@denbezrukov
Copy link
Contributor

Could I try to fix it?🙏

denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 11, 2022
@denbezrukov
fix(rome_js_parser): Allow super in constructor parameter rome#3613
0ccb128
@denbezrukov denbezrukov mentioned this issue Nov 11, 2022
Merged
MichaReiser pushed a commit that referenced this issue Nov 13, 2022
@denbezrukov
fix(rome_js_parser): Allow super in constructor parameter #3613 (#3678)
e89e6b2 
Fix #3613
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denbezrukov denbezrukov

Labels
A-Parser Area: parser L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rome_js_parser): Allow super in constructor parameter #3613 denbezrukov/tools
2 participants
@MichaReiser @denbezrukov