🐛 Various spacing/line length formatting incompatibilities with Prettier

[nstepien]

Environment information

OS: win11, 64bit
install: `npm i rome@nightly`

What happened?

1. Open this playground
2. Notice the multiple formatting differences between the Rome output and Prettier output

Expected result

Prettier compatibility.

I've tested Nightly Rome's formatter in our biggest codebase, and these were the only differences I found.

Code of Conduct

• I agree to follow Rome's Code of Conduct

[unvalley]

I'll take a look. We can split this task to:

• shothanded named import line break with default
  • fix(rome_js_formatter): shothanded named import line break with default import #3826
• export line break
  • fix(rome_js_formatter): restrict export line break for single specifier #3726
• jsx comment to props (specifically props count is 2, and comment to 2nd)
• jsx whitespace is meaningful jsx text
• jsx whitespace in childNodes with long strings
  • fix(rome_js_formatter): jsx whitespace is meaningful jsx text #3732
• object destructing in arguments (playground) from nsteien's comment
  • fix(rome_js_formatter): Inline object like pattern for formal parameter #3802
• single-character-in-jsx formatting
  • fix(rome_js_formatter): jsx punctuation #3842

[nstepien]

I have found some more incompatibility with prettier: playground

[nstepien]

Yet another example: playground

[MichaReiser]

I'll take a look. We can split this task to:

* [ ]  imports/exports line break

* [ ]  JSX comment to props (specifically props count is 2, and comment to 2nd)

* [ ]  JSX space in childNodes

* [ ]  JSX space in childNodes with long strings

@unvalley Are you looking into all these issues or some of them? Can other contributors help you with some of the work?

[unvalley]

@MichaReiser

Can other contributors help you with some of the work?

Yes, thanks.
I'm working on import/exports line break now. Other tasks remain.

[unvalley]

I'll work on fixing to named import line break.

[denbezrukov]

I have found some more incompatibility with prettier: playground

I can help with this =)

[nstepien]

Probably the last prettier incompatibility I'll find, seems very very minor though: playground

[MichaReiser]

Probably the last prettier incompatibility I'll find, seems very very minor though: playground

That might be a tough one. Prettier has some special handling for single character texts that we don't fully support yet.

[nstepien]

Yeah I personally don't mind if this doesn't get fixed.
Maybe it affects other repos differently.

[nstepien]

Does anyone want to look into the single-character-in-jsx formatting incompatibility?

Otherwise I'm happy with closing this issue, thank you everyone!

[denbezrukov]

Does anyone want to look into the single-character-in-jsx formatting incompatibility?

Otherwise I'm happy with closing this issue, thank you everyone!

I'll check it =)