incorporate is_exported into noUnusedVariables

rome · Aug 10, 2022 · c0f2624 · c0f2624
1 parent f18dc45
commit c0f2624
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/crates/rome_js_analyze/src/semantic_analyzers/no_unused_variables/no_unused_variables.rs b/crates/rome_js_analyze/src/semantic_analyzers/no_unused_variables/no_unused_variables.rs
@@ -124,6 +124,10 @@ impl Rule for NoUnusedVariables {
             return None;
         }
 
+        if model.is_exported(binding) {
+            return None;
+        }
+
         let all_references = binding.all_references(model);
 
         if all_references.count() == 0 {

diff --git a/crates/rome_js_analyze/tests/specs/no_unused_variables/noUnusedVariables.js b/crates/rome_js_analyze/tests/specs/no_unused_variables/noUnusedVariables.js
@@ -37,3 +37,8 @@ const f6 = () => {
 
 try {
 } catch (e) {}
+
+export function exported_function() {}
+
+function exported_function_2() {}
+export { exported_function_2 };
diff --git a/crates/rome_js_analyze/tests/specs/no_unused_variables/noUnusedVariables.js.snap b/crates/rome_js_analyze/tests/specs/no_unused_variables/noUnusedVariables.js.snap
@@ -44,6 +44,11 @@ const f6 = () => {
 try {
 } catch (e) {}
 
+export function exported_function() {}
+
+function exported_function_2() {}
+export { exported_function_2 };
+
 ```
 
 # Diagnostics
@@ -264,7 +269,7 @@ warning[no_unused_variables/noUnusedVariables]: This variable is unused.
    │       --
 
 Suggested fix: Remove this variable.
-      | @@ -31,9 +31,5 @@
+      | @@ -31,10 +31,6 @@
 30 30 |   
 31 31 |   const f5 = () => {};
 32 32 |   
@@ -274,6 +279,7 @@ Suggested fix: Remove this variable.
 36    | - 
 37 33 |   try {
 38 34 |   } catch (e) {}
+39 35 |   
 
 =  note: Unused variables usually are result of incomplete refactoring, typos and other source of bugs.
 
@@ -288,12 +294,15 @@ warning[no_unused_variables/noUnusedVariables]: This variable is unused.
    │          -
 
 Suggested fix: Remove this variable.
-      | @@ -36,4 +36,4 @@
+      | @@ -36,7 +36,7 @@
 35 35 |   };
 36 36 |   
 37 37 |   try {
 38    | - } catch (e) {}
    38 | + } catch {}
+39 39 |   
+40 40 |   export function exported_function() {}
+41 41 |   
 
 =  note: Unused variables usually are result of incomplete refactoring, typos and other source of bugs.