-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance error reporting and clean code #20
Comments
Hello again, |
Sorry for the delay. This patch only adds some better error reporting via tracking the tree. It's not perfect yet, so it's better to check in a separate branch. I'm not a dub hand in githubbing, if your github-fu is better than mine —you can handle this :) Also, I didn't do anything in "code cleaning" - or rather in proper code hinting (I'm getting more that PHP 350 warnings in PHPStorm) as this task it too difficult for now and requires separate analysis. |
Thank you! The patch is pretty substantial, I will review it tomorrow. |
It seems to me the bad part of this tool is error reporting as it rarely reports anything reasonable when validating schema for example.
So I started to enhance this part. I'm not sure though what is the best way to do so due to architecture specifics: exceptions logic is mixed with real errors and it's very difficult to distinguish.
I'm going to provide a PR today so that you @romaricdrigon could check it out.
P.S. While I was editing this message I got notification that you finally replied in my other issue lol
The text was updated successfully, but these errors were encountered: