Skip to content

Bump MSRV to 1.63.0 and update dependencies #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romanz merged 1 commit into from
Jun 10, 2023
Merged

Bump MSRV to 1.63.0 and update dependencies #773

romanz merged 1 commit into from
Jun 10, 2023

Conversation

@romanz
Copy link
Owner

@romanz romanz commented Oct 7, 2022 •
edited
Loading

Fixes #753 (allow rocksdb build on Mac OS).
Fixes #877 (support GCC 13).

@romanz romanz force-pushed the bump-msrv branch 4 times, most recently from 45f4fe2 to 31b6e32 Compare October 7, 2022 18:34
@romanz romanz force-pushed the bump-msrv branch 4 times, most recently from 9070cdd to 8b2dc59 Compare October 28, 2022 06:05
@Kixunil
Copy link
Contributor

Kixunil commented Nov 3, 2022

Is the plan to wait until bookworm is released? (It has 1.61.0)

@romanz
Copy link
Owner Author

romanz commented Nov 3, 2022

Yes, let's wait for it.

@romanz romanz mentioned this pull request Nov 6, 2022
Closed
@romanz romanz force-pushed the bump-msrv branch 2 times, most recently from f09f576 to d5096aa Compare January 14, 2023 19:32
@romanz
Copy link
Owner Author

romanz commented Feb 3, 2023

Opened spesmilo/electrum#8185 to allow Electrum integration testing on the next Debian release.

@romanz romanz force-pushed the bump-msrv branch 2 times, most recently from 0b1bea2 to 4a5d709 Compare February 4, 2023 21:19
@Kixunil
Copy link
Contributor

Kixunil commented Feb 17, 2023

Bookworm now has 1.63 if it helps anything.

@romanz romanz changed the title Bump MSRV to 1.60.0 and update dependencies Bump MSRV to 1.63.0 and update dependencies Feb 17, 2023
@nymkappa
Copy link

nymkappa commented Feb 27, 2023 •
edited
Loading

Thanks a lot. I confirm it builds and runs fine on Apple M1 Max using this branch, while v0.9.12 did not.

@romanz romanz force-pushed the bump-msrv branch 6 times, most recently from 9db6db9 to dac2869 Compare March 3, 2023 16:52
@Kixunil
Copy link
Contributor

Kixunil commented Mar 19, 2023

Cargo.toml should be updated too since this would fail to build with -Z minimal-versions

Also I recently noticed that configure_me_codegen has man feature on by default which pulls unnecessary man and roff crates. default-features = false fixes it.

@romanz
Copy link
Owner Author

romanz commented Mar 20, 2023

Good catch - thanks @Kixunil !

@romanz romanz force-pushed the bump-msrv branch 6 times, most recently from 5a88092 to edc8ce2 Compare March 31, 2023 09:33
@antonilol antonilol mentioned this pull request Apr 11, 2023
Closed
5 tasks
@romanz romanz mentioned this pull request Apr 13, 2023
Closed
@romanz romanz force-pushed the bump-msrv branch 2 times, most recently from f4f1988 to 5076afc Compare April 14, 2023 18:13
@antonilol antonilol mentioned this pull request May 7, 2023
Closed
@romanz
Copy link
Owner Author

romanz commented May 14, 2023 •
edited
Loading

Since Debian 12 is planned to be released next month, I plan to merge this PR afterwards - bumping MSRV to 1.63 and updating multiple dependencies (such as RocksDB).

If possible, I would appreciate if you could please test this branch on multiple devices (especially on ARM-based platforms) and Bitcoin-related distributions. Many thanks in advance :)

CC: @Kixunil @Pantamis @craigraw @openoms @rootzoll @lukechilds @ascisco @raelschiffler @kentschubert @roshan-dias @afilini @ulzeraj @Overtorment @Stadicus @jlopp @shesek

@romanz romanz added the enhancement New feature or request label May 14, 2023
@romanz romanz self-assigned this May 14, 2023
@romanz romanz mentioned this pull request May 15, 2023
Closed
@romanz
Copy link
Owner Author

romanz commented May 19, 2023

https://lists.debian.org/debian-devel-announce/2023/04/msg00007.html

@romanz romanz force-pushed the bump-msrv branch 2 times, most recently from b9b7fde to b960c89 Compare May 25, 2023 18:27
@romanz romanz merged commit d2c794c into master Jun 10, 2023
@romanz romanz deleted the bump-msrv branch June 10, 2023 18:42
@romanz romanz mentioned this pull request Jun 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@romanz romanz

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

Build: compiling dependency electrs-librocksdb-sys fails with gcc 13 Rocksdb build error on an M1 Mac

3 participants

@romanz @Kixunil @nymkappa