Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Use new context functions, fix issue when resolveId returns an object #387

Merged
merged 13 commits into from
May 15, 2019

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented May 14, 2019

This PR gets rid of a lot of special logic by using things built into (the current and an upcoming) version of Rollup. Mainly, rollup/rollup#2844 will add an option skipSelf to this.resolve which replaces the custom logic of this plugin with a more predictable one. Also this should provide a slight performance boost as we get rid of some unnecessary promises (the transform hook will be sync after this PR!).

Furthermore, this changes the format of plugin-generated proxy ids to \0./original/import/path?commonjs-proxy to allow for plugins like rollup-plugin-global-externals to more easily filter for those modules by just removing the leading \0.

@lukastaegert lukastaegert merged commit c8fabd7 into master May 15, 2019
@lukastaegert lukastaegert deleted the use-new-resolveer branch May 15, 2019 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant