This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Use new context functions, fix issue when resolveId returns an object #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2019
lukastaegert
force-pushed
the
use-new-resolveer
branch
from
78617b3
to
d7a39da
Compare
lukastaegert
force-pushed
the
use-new-resolveer
branch
from
ba2ba36
to
300ebf5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of a lot of special logic by using things built into (the current and an upcoming) version of Rollup. Mainly, rollup/rollup#2844 will add an option
skipSelftothis.resolvewhich replaces the custom logic of this plugin with a more predictable one. Also this should provide a slight performance boost as we get rid of some unnecessary promises (the transform hook will be sync after this PR!).Furthermore, this changes the format of plugin-generated proxy ids to
\0./original/import/path?commonjs-proxyto allow for plugins like rollup-plugin-global-externals to more easily filter for those modules by just removing the leading\0.