Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Add support for importing index.js from aliased directories path #38

Closed
wants to merge 2 commits into from

Conversation

soanvig
Copy link

@soanvig soanvig commented Jan 20, 2018

Fix #37

I have written new tests, and tested it in one of my local projects. Everything works I think, but one may look into tests, because I'm not expert in testing.

@soanvig
Copy link
Author

soanvig commented Jan 20, 2018

Appveyor test returns false, while Travis true. Not sure if my patch destroyed something, but it shouldn't. This may be false negative check, at least for that PR.

@leesiongchan
Copy link

Why is this hasn't been merged?

@soanvig
Copy link
Author

soanvig commented Apr 13, 2018

Repo is inactive for a long time. I could be eager to take ownership if I maintain more projects, that use Rollup. For now I have only one or two such.

@soanvig
Copy link
Author

soanvig commented Apr 13, 2018

You may want to use directly my fork (npm supports external repositories). You may see Google, if you don't know what Im talking about.

@frostney
Copy link
Contributor

frostney commented May 2, 2018

Hi @soanvig, thank you for your pull request. I've commented on the corresponding issue (#37) as well.

The idea here is that Rollup plugins have a specific responsibility. For this plugin it's to only provide aliases, but not to enhance the resolution algorithm in any other way.

The recommended approach is to use rollup-plugin-node-resolve which allows to resolve index.js files and use it in conjuction with rollup-plugin-alias. Please feel free to open an issue if that doesn't work you.

If you think this is still unresolved, leave a comment and I'm happy to discuss this further.

@frostney frostney closed this May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants