feat(commonjs): set syntheticNamedExports for commonjs modules

package.json

@@ -31,7 +31,7 @@
     "pnpm": "^4.3.0",
     "prettier": "^1.19.1",
     "prettier-plugin-package": "^0.3.1",
-    "rollup": "^1.27.2",
+    "rollup": "^1.28.0",
     "ts-node": "^8.5.2",
     "tsconfig-paths": "^3.9.0",
     "tslib": "^1.10.0",

packages/commonjs/package.json

@@ -68,7 +68,7 @@
     "mocha": "^6.1.4",
     "prettier": "^1.18.2",
     "require-relative": "^0.8.7",
-    "rollup": "^1.16.2",
+    "rollup": "^1.28.0",
     "rollup-plugin-babel": "^4.3.3",
     "@rollup/plugin-json": "^4.0.0",
     "@rollup/plugin-node-resolve": "^6.0.0",

packages/commonjs/src/transform.js

@@ -511,12 +511,13 @@ export function transformCommonjs(
     .trim()
     .append(wrapperEnd);
 
-  if (hasDefaultExport || named.length > 0 || shouldWrap || !isEntry) {
+  const injectExportBlock = hasDefaultExport || named.length > 0 || shouldWrap || !isEntry;
+  if (injectExportBlock) {
     magicString.append(exportBlock);
   }
 
   code = magicString.toString();
   const map = sourceMap ? magicString.generateMap() : null;
 
-  return { code, map };
+  return { code, map, syntheticNamedExports: injectExportBlock };
 }

packages/commonjs/test/fixtures/function/__esModule/main.js

@@ -2,4 +2,3 @@ import * as x from './answer';
 
 t.truthy('answer' in x);
 t.truthy('default' in x);
-t.truthy(!('__esModule' in x));

packages/commonjs/test/fixtures/function/named-exports-conditional/main.js

@@ -0,0 +1,3 @@
+import { named } from './x.js';
+
+t.is(named, 'foo');

packages/commonjs/test/fixtures/function/named-exports-conditional/x.js

@@ -0,0 +1,5 @@
+if (typeof someUnknownGlobal !== 'undefined') {
+  module.exports = { named: 'bar' };
+} else {
+  module.exports = { named: 'foo' };
+}

packages/commonjs/test/fixtures/function/named-exports-dynamic/_config.js

@@ -0,0 +1,5 @@
+module.exports = {
+  context: {
+    window: { }
+  }
+};

packages/commonjs/test/fixtures/function/named-exports-dynamic/main.js

@@ -0,0 +1,7 @@
+import { named } from './x.js';
+
+t.is(named, undefined);
+
+window.addExport('named', 'foo');
+
+t.is(named, 'foo')

packages/commonjs/test/fixtures/function/named-exports-dynamic/x.js

@@ -0,0 +1,3 @@
+window.addExport = (key, value) => {
+  module.exports[key] = value;
+}

packages/commonjs/test/fixtures/function/named-exports-object-define/main.js

@@ -0,0 +1,3 @@
+import { named } from './x.js';
+
+t.is(named, 'foo');

packages/commonjs/test/fixtures/function/named-exports-object-define/x.js

@@ -0,0 +1,6 @@
+Object.defineProperty(module.exports, 'named', {
+  enumerable: true,
+  get: function get() {
+    return 'foo';
+  }
+});

packages/commonjs/test/fixtures/function/named-exports-reexport-default/export.js

@@ -0,0 +1 @@
+exports.named = 2;

packages/commonjs/test/fixtures/function/named-exports-reexport-default/main.js

@@ -0,0 +1,3 @@
+import { named } from './reexport.js';
+
+t.is(named, 2);

packages/commonjs/test/fixtures/function/named-exports-reexport-default/reexport.js

@@ -0,0 +1 @@
+module.exports = require('./export.js');

packages/commonjs/test/fixtures/function/named-exports-reexport-named/export.js

@@ -0,0 +1 @@
+exports.named = 2;

packages/commonjs/test/fixtures/function/named-exports-reexport-named/main.js

@@ -0,0 +1,3 @@
+import { named } from './reexport.js';
+
+t.is(named, 2);

packages/commonjs/test/fixtures/function/named-exports-reexport-named/reexport.js

@@ -0,0 +1,3 @@
+const myModule = require('./export.js');
+
+module.exports.named = myModule.named;

packages/commonjs/test/fixtures/function/named-exports-unexported/main.js

@@ -0,0 +1,3 @@
+import { nonExisting } from './x.js';
+
+t.is(nonExisting, undefined);

packages/commonjs/test/fixtures/function/named-exports-unexported/x.js

@@ -0,0 +1 @@
+exports.named = 2;

packages/commonjs/test/form.js

@@ -56,6 +56,7 @@ readdirSync('./fixtures/form').forEach((dir) => {
 
     const transformed = transform.call(transformContext, input, id);
     const actual = (transformed ? transformed.code : input).trim().replace(/\0/g, '_');
+
     t.is(actual, expected);
   });
 });

packages/commonjs/test/test.js

@@ -393,20 +393,6 @@ test('does not process the entry file when it has a leading "." (issue #63)', as
   await t.notThrowsAsync(executeBundle(bundle, t));
 });
 
-test('does not reexport named contents', async (t) => {
-  try {
-    await rollup({
-      input: 'fixtures/samples/reexport/main.js',
-      plugins: [commonjs()]
-    });
-  } catch (error) {
-    t.is(
-      error.message,
-      `'named' is not exported by fixtures/samples${path.sep}reexport${path.sep}reexport.js`
-    );
-  }
-});
-
 test('respects other plugins', async (t) => {
   const bundle = await rollup({
     input: 'fixtures/samples/other-transforms/main.js',