Skip to content

refactor: remove never-constructed ImportStatus variants #9606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 30, 2026
Merged

refactor: remove never-constructed ImportStatus variants #9606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions crates/rolldown/src/stages/link_stage/bind_imports_and_exports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,6 @@ pub enum ImportStatus {
commonjs_symbol: SymbolRef,
},

/// The import was treated as a CommonJS import but the file is known to have no exports
_CommonJSWithoutExports,

/// The imported file was disabled by mapping it to false in the "browser" field of package.json
_Disabled,

/// The imported file is external and has unknown exports
External(SymbolRef),
}
Expand Down Expand Up @@ -1169,12 +1163,6 @@ impl BindImportsAndExportsContext<'_> {

break MatchImportKind::Normal(MatchImportKindNormal { symbol, reexports });
}
ImportStatus::_CommonJSWithoutExports => {
panic!("`ImportStatus::_CommonJSWithoutExports` is not implemented yet")
}
ImportStatus::_Disabled => {
panic!("`ImportStatus::_Disabled` is not implemented yet")
}
ImportStatus::External(symbol_ref) => {
if self.options.format.keep_esm_import_export_syntax() {
// Imports from external modules should not be converted to CommonJS
Expand Down
Loading