Skip to content

feat(hmr): remove babel @babel/plugin-transform-modules-commonjs#2232

Merged
underfin merged 2 commits into
hmr-pocfrom
09-13-feat_hmr_remove_babel_babel_plugin-transform-modules-commonjs
Sep 15, 2024
Merged

feat(hmr): remove babel @babel/plugin-transform-modules-commonjs#2232
underfin merged 2 commits into
hmr-pocfrom
09-13-feat_hmr_remove_babel_babel_plugin-transform-modules-commonjs

Conversation

@underfin
Copy link
Copy Markdown
Contributor

Description

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 14, 2024

Benchmarks Rust

  • target: hmr-poc(1d2c9ac)
  • pr: 09-13-feat_hmr_remove_babel_babel_plugin-transform-modules-commonjs(d5a286b)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.5±0.62ms        ? ?/sec    1.01     53.1±0.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     75.0±0.87ms        ? ?/sec    1.01     76.0±0.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     92.3±0.87ms        ? ?/sec    1.01     93.1±1.35ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     61.1±0.81ms        ? ?/sec    1.02     62.2±1.40ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.2±1.03ms        ? ?/sec    1.01    102.3±3.65ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    175.9±1.74ms        ? ?/sec    1.01    177.2±2.29ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    221.7±2.12ms        ? ?/sec    1.00    221.1±1.74ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.5±0.78ms        ? ?/sec    1.00    116.5±0.90ms        ? ?/sec
bundle/bundle@threejs                                               1.01     33.3±0.47ms        ? ?/sec    1.00     32.8±0.60ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     74.3±1.56ms        ? ?/sec    1.00     72.7±1.02ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.01     93.0±2.48ms        ? ?/sec    1.00     91.9±0.29ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     41.7±0.18ms        ? ?/sec    1.02     42.5±0.39ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    350.0±3.91ms        ? ?/sec    1.00    344.8±2.03ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    956.2±3.99ms        ? ?/sec    1.00    953.2±3.98ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1235.0±11.25ms        ? ?/sec    1.00   1232.2±8.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    416.2±3.10ms        ? ?/sec    1.01    419.1±2.97ms        ? ?/sec
remapping/remapping                                                 1.00     32.4±0.31ms        ? ?/sec    1.01     32.6±0.64ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     81.2±0.75ms        ? ?/sec    1.02     83.0±0.56ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.7±0.63ms        ? ?/sec    1.01     82.2±0.75ms        ? ?/sec
scan/scan@threejs                                                   1.01     25.6±1.01ms        ? ?/sec    1.00     25.4±0.12ms        ? ?/sec
scan/scan@threejs10x                                                1.00    255.5±1.73ms        ? ?/sec    1.01    257.4±3.22ms        ? ?/sec

Base automatically changed from 09-13-fix_hmr_reuse_symbols_info_for_hmr to hmr-poc September 15, 2024 11:22
@underfin underfin force-pushed the 09-13-feat_hmr_remove_babel_babel_plugin-transform-modules-commonjs branch from 2f04b60 to d5a286b Compare September 15, 2024 11:26
@underfin underfin merged commit aa5a76a into hmr-poc Sep 15, 2024
@underfin underfin deleted the 09-13-feat_hmr_remove_babel_babel_plugin-transform-modules-commonjs branch September 15, 2024 11:30
underfin added a commit that referenced this pull request Nov 5, 2024
<!-- Thank you for contributing! -->

### Description

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant