Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename KSCrash types, functions and files to RollbarCrash to avoid collisions #301

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 4, 2023

Description of the change

KSCrash license is still in every source as mandated by it.

This PR is being merged into the kscrash_integration feature branch, not on master.

Renames help us avoid naming collisions if someone decides to use KSCrash along our library, to avoid confusion and signal our version diverges from the original library.

This also helps ease errors that begun due to Xcode 14.3 updates, more info. See also: swiftlang/swift#64669.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 4, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #127332: Unable to integrate Apple SDK to Frameworks.

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor and rename will make things clearer and allow us to more configurability to a stale library. Thanks, LGTM.

@matux
Copy link
Collaborator Author

matux commented Jul 6, 2023

This will fix the name ambiguity linking issues and potential collisions, too!

@matux matux merged commit 7df25c5 into kscrash_integration Jul 6, 2023
@matux matux deleted the rename_src branch July 6, 2023 16:14
@matux matux mentioned this pull request Jul 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants