Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pathlib.Path() objects #450

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

singingwolfboy
Copy link
Contributor

@singingwolfboy singingwolfboy commented May 17, 2024

Fixes #345. This change allows Rollbar to convert pathlib.Path objects to regular strings for serialization purposes. This also prevents Rollbar from crashing in the default Django configuration, where settings.BASE_DIR is a PosixPath object.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell self-requested a review May 17, 2024 22:18
@danielmorell danielmorell self-assigned this May 17, 2024
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singingwolfboy Thank you for putting this together! This looks great!

@danielmorell danielmorell merged commit 46fb38d into rollbar:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting 'PosixPath' object has no attribute 'lower' with django
2 participants