Fixed shortener multi level shortening #449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes the key matching shortener logic that was preventing deep shortening of the payload.
There are a few significant changes here:
'*'
key will not only match everything at that level it will also match all of the children of that key.maxlevel
. Each level deep than the shortener key is checked to see if it exceeds themaxlevel
. This is only applied if the key matches and ends with a final'*'
key.Because this may have a meaningful change in the frame data we are sending, I think this should be a minor change not a patch. I also think we should release this as a beta initially. This would be
v1.1.0-beta0
.Type of change
Related issues
Checklists
Development
Code review