Twisted should not install log handler automatically

[gdoermann]

Rollbar automatically installs the log observer for twisted upon import. This is a massive issue if you never initialize rollbar or if the initialization fails. The log observer should be added after you call rollbar.init(handler='twisted', **settings.ROLLBAR) so that you can verify it will work before sending messages to the observer. If you do not initialize rollbar the observer will receive messages but will err out until it completely blocks the twisted loop.

[ezarowny]

Ah, nice find! Thanks!

[ezarowny]

I'll take a crack at this.

[rokob]

Why does sending messages to the observer that is uninitialized cause problems? Shouldn't that just be a no-op?

[gdoermann]

We were having issues with twisted freezing when using rollbar client (in twisted mode). At first we just stopped initializing rollbar but it did not fix it because twisted was running so the rollbar observer was running and throwing a lot of errors saying we needed to initialize before trying to send.

…

Sent from my iPhone

On Jun 16, 2017, at 2:02 PM, Andrew Weiss ***@***.***> wrote: Why does sending messages to the observer that is uninitialized cause problems? Shouldn't that just be a no-op? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ezarowny]

Could you give #171 a try for me?