-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow set preset and fix go to preset #520
Conversation
Still need to test locally before merging.... Fighting with compile process. |
web tested! |
The preset implementation contained in ipc_cmd is not complete.
Do you think it's enough to make the feature usable? |
I will merge this pr and I will add the missing part (mainly ipc_cmd). |
Sorry for the delay, For what I tested I thought this was overriding the "last selected preset", but it appears to be appending to last preset as you mention. Having labels for presets might need to have Yi-Hack to store and manage the preset references, so I'd leave that up to you on how to better handle it. Sure, I can provide the changes for MQTT :) |
The IPC command to add a preset doesn't accept arguments about where to store the preset.
This is the hard part. The app stores a snapshot of the preset so you can recognize it. The hack cannot read the snapshot because it's not stored in the cam (I think). So, this is my thought:
|
Since the
set_preset
function is currently implemented inipc_cmd
, I'm adding it to the Web-UI.POST /preset.sh