Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT camera settings not working #516

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Oct 23, 2022

Unfortunately, the initial way the script was done would only apply the "first setting found in MQTT", changing the rest would not apply.
Instead, what we want to do is have a MQTT client subscribed permanently to the topics, and perform the changes when requested.
⚠️ NOTE: This will only apply/work when changes are done through MQTT.

This PR also provides:

  • Fixes spamming settings in $MQTT_PREFIX/camera_setting every second
  • Allow setting "on/off" besides "yes/no"
  • Rework of the ipc_cmd flag option to be more readable
  • Run ipc_cmd in background to speed up changing settings

Fixes #469
Fixes #407
Fixes #337

@roleoroleo
Copy link
Owner

Thank you for your pr.

@roleoroleo roleoroleo merged commit 467e9f3 into roleoroleo:master Oct 26, 2022
@duhow duhow deleted the fix-mqtt-settings branch October 26, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants