Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for custom tls config #20

Merged
merged 6 commits into from
May 31, 2020
Merged

add support for custom tls config #20

merged 6 commits into from
May 31, 2020

Conversation

fate0
Copy link
Contributor

@fate0 fate0 commented May 28, 2020 •
edited
Loading

  • Update Readme
  • Add test case

@rogerwelin rogerwelin marked this pull request as ready for review May 30, 2020 11:49
@rogerwelin
Copy link
Owner

Hi @fate0, thanks for the contribution! I tested your branch locally and it works as expected running it against a x509 auth server, also code looks fine.

A simple README update and then we can merge. Also tests if possible

@fate0
Copy link
Contributor Author

fate0 commented May 31, 2020

@rogerwelin done, it is ready for review

@fate0 fate0 changed the title [WIP] add support for custom tls config add support for custom tls config May 31, 2020
@rogerwelin
Copy link
Owner

@fate0 Looks good, will draft a new release. Thanks for the great contribution

@rogerwelin rogerwelin merged commit cff7785 into rogerwelin:master May 31, 2020
@rogerwelin rogerwelin linked an issue May 31, 2020 that may be closed by this pull request
add support for x509 authentication #6
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for x509 authentication
2 participants
@fate0 @rogerwelin