add GA for push and pull-request & fixing code smells

.github/pullrequest.yaml

@@ -0,0 +1,23 @@
+name: pipeline
+
+on: [push, pull_request]
+name: Test
+jobs:
+  test:
+    strategy:
+      matrix:
+        go-version: [1.15.x]
+        os: [ubuntu-latest, macos-latest, windows-latest]
+    runs-on: ${{ matrix.os }}
+
+    steps:
+    - name: Install Go
+      uses: actions/setup-go@v2
+      with:
+        go-version: ${{ matrix.go-version }}
+
+    - name: Checkout code
+      uses: actions/checkout@v2
+
+    - name: Unit-tests
+      run: go test -v ./...

cmd/cassowary/cli.go

@@ -19,11 +19,11 @@ import (
 
 var (
 	version             = "dev"
-	errConcurrencyLevel = errors.New("Error: Concurrency level cannot be set to: 0")
-	errRequestNo        = errors.New("Error: No. of request cannot be set to: 0")
-	errNotValidURL      = errors.New("Error: Not a valid URL. Must have the following format: http{s}://{host}")
-	errNotValidHeader   = errors.New("Error: Not a valid header value. Did you forget : ?")
-	errDurationValue    = errors.New("Error: Duration cannot be set to 0 or negative")
+	errConcurrencyLevel = errors.New("error: Concurrency level cannot be set to: 0")
+	errRequestNo        = errors.New("error: No. of request cannot be set to: 0")
+	errNotValidURL      = errors.New("error: Not a valid URL. Must have the following format: http{s}://{host}")
+	errNotValidHeader   = errors.New("error: Not a valid header value. Did you forget : ?")
+	errDurationValue    = errors.New("error: Duration cannot be set to 0 or negative")
 )
 
 func outPutResults(metrics client.ResultMetrics) {
@@ -121,7 +121,7 @@ func validateCLI(c *cli.Context) error {
 		}
 	}
 
-	if client.IsValidURL(c.String("url")) == false {
+	if !client.IsValidURL(c.String("url")) {
 		return errNotValidURL
 	}
 

go.mod

@@ -1,6 +1,6 @@
 module github.com/rogerwelin/cassowary
 
-go 1.14
+go 1.15
 
 require (
 	github.com/aws/aws-sdk-go v1.30.24

pkg/client/load.go

@@ -106,7 +106,7 @@ func (c *Cassowary) runLoadTest(outPutChan chan<- durationMetrics, workerChan ch
 			resp.Body.Close()
 		}
 
-		if c.DisableTerminalOutput != true {
+		if !c.DisableTerminalOutput {
 			c.Bar.Add(1)
 		}
 
@@ -170,7 +170,7 @@ func (c *Cassowary) Coordinate() (ResultMetrics, error) {
 
 	c.Bar = progressbar.New(c.Requests)
 
-	if c.DisableTerminalOutput != true {
+	if !c.DisableTerminalOutput {
 		col := color.New(color.FgCyan).Add(color.Underline)
 		col.Printf("\nStarting Load Test with %d requests using %d concurrent users\n\n", c.Requests, c.ConcurrencyLevel)
 	}
@@ -232,7 +232,7 @@ func (c *Cassowary) Coordinate() (ResultMetrics, error) {
 	close(channel)
 
 	end := time.Since(start)
-	if c.DisableTerminalOutput != true {
+	if !c.DisableTerminalOutput {
 		fmt.Println(end)
 	}