Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use individual board makefiles #94

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GrantM11235
Copy link
Contributor

make <board> creates bootloader_only_binaries/<board>.bin by including boards/<board>.mk.

make all runs make <board> for every board in the boards/.

This dramatically simplifies the makefile and makes it much easier to maintain and add new boards.

This pull request (and each individual commit) should produce binaries that are identical to the master branch:

git checkout master
sh make_all.bat
md5sum bootloader_only_binaries/* > binaries.md5
git checkout board-makefiles
rm bootloader_only_binaries/*
make all
md5sum -c binaries.md5
#bootloader_only_binaries/cc3d.bin: OK
#bootloader_only_binaries/dso138_boot20.bin: OK
#bootloader_only_binaries/gd32f1_frankenmaple.bin: OK
#bootloader_only_binaries/gd32f1_generic_boot20_pc13.bin: OK
#bootloader_only_binaries/generic_boot20_hytiny.bin: OK
#bootloader_only_binaries/generic_boot20_pa1.bin: OK
#bootloader_only_binaries/generic_boot20_pa1_button_pa8.bin: OK
#bootloader_only_binaries/generic_boot20_pa9.bin: OK
#bootloader_only_binaries/generic_boot20_pb0.bin: OK
#bootloader_only_binaries/generic_boot20_pb12.bin: OK
#bootloader_only_binaries/generic_boot20_pb7.bin: OK
#bootloader_only_binaries/generic_boot20_pb9.bin: OK
#bootloader_only_binaries/generic_boot20_pc13.bin: OK
#bootloader_only_binaries/generic_boot20_pc13_fastboot.bin: OK
#bootloader_only_binaries/generic_boot20_pd1.bin: OK
#bootloader_only_binaries/generic_boot20_pd2.bin: OK
#bootloader_only_binaries/generic_boot20_pe2.bin: OK
#bootloader_only_binaries/generic_boot20_pe5.bin: OK
#bootloader_only_binaries/generic_boot20_pe5_button_pa0.bin: OK
#bootloader_only_binaries/generic_boot20_pg15.bin: OK
#bootloader_only_binaries/generic-none_bootloader.bin: OK
#bootloader_only_binaries/maple_mini_boot20.bin: OK
#bootloader_only_binaries/maple_rev3_boot20.bin: OK
#bootloader_only_binaries/maple_rev5_boot20.bin: OK
#bootloader_only_binaries/naze32_boot20.bin: OK
#bootloader_only_binaries/smart-v2.bin: OK
#bootloader_only_binaries/stbee_boot20.bin: OK

@rogerclarkmelbourne
Copy link
Owner

Thanks

I'll try it on my PC

@mjeveritt
Copy link

This seems a sensible improvement; is there anything blocking its merging? TIA!

@GrantM11235
Copy link
Contributor Author

I just checked this again, it still produces identical binaries. In my opinion this is ready to be merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants