fix: avoid implicit dependency on tailwind #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally if
tailwind-config-vieweris installed as a dependency, it is expected thattailwindis also installed alongside. But when it is used as a sub-dependency like in@nuxtjs/tailwindcss, package manager might hoist it to top-levelnode_moduleswhiletailwinddependency will not be hoisted and require cannot work anymore. To avoid such issues we should always explicitly define any imported dependency independenciesorpeerDependencies. (current ranges checked by https://semver.npmjs.com)This PR also extends require path to first search for
tailwindfrom package (default require behavior) and then fallback to cwd for supporting global install conditions.Resolves nuxt-modules/tailwindcss#297