feat: run timer logic every tick to enable tick based timers

managed/CounterStrikeSharp.API/Core/BasePlugin.cs

@@ -40,7 +40,7 @@
     {
         private bool _disposed;
 
         public BasePlugin()
         {
             RegisterListener<Listeners.OnMapEnd>(() =>
             {
@@ -370,6 +370,21 @@
             return timer;
         }
 
+        /// <summary>
+        /// Adds a timer that will call the given callback after the specified amount of ticks.
+        /// By default will only run once unless the <see cref="TimerFlags.REPEAT"/> flag is set.
+        /// </summary>
+        /// <param name="interval">Interval/Delay in ticks</param>
+        /// <param name="callback">Code to run when timer elapses</param>
+        /// <param name="flags">Controls if the timer is a one-off, repeat or stops on map change etc.</param>
+        /// <returns>An instance of the <see cref="Timer"/></returns>
+        public Timer AddTickTimer(int tickInterval, Action callback, TimerFlags? flags = null)
+        {
+            var timer = new Timer(tickInterval * Server.TickInterval, callback, flags ?? 0);
+            Timers.Add(timer);
+            return timer;
+        }
+
         /// <summary>
         /// Registers all attribute handlers on the given instance.
         /// Can be used to register event handlers, console commands, entity outputs etc. from classes that are not derived from `BasePlugin`.
@@ -511,7 +526,7 @@
             }
         }
 
         public void RegisterFakeConVars(Type type, object instance = null)
         {
             var convars = type
                 .GetFields(BindingFlags.Public | BindingFlags.Instance | BindingFlags.Static)

managed/CounterStrikeSharp.Tests.Native/SchemaTests.cs

@@ -1,4 +1,5 @@
 using System.Linq;
+using System.Threading;
 using System.Threading.Tasks;
 using CounterStrikeSharp.API;
 using CounterStrikeSharp.API.Core;
@@ -14,7 +15,19 @@ public void GetSchemaOffset_ReturnsValidOffset()
     {
         var offset = NativeAPI.GetSchemaOffset("CBaseEntity", "m_iHealth");
 
-        Assert.True(offset > 0, $"Schema offset for m_iHealth should be positive, got {offset}");
+        Assert.Equal(1464, offset); // Hardcode for now, this may change but I want to know if it changes
+    }
+
+    [Fact]
+    public async Task GetSchemaOffset_CanRunOnAnotherThread()
+    {
+        await Task.Run(async () =>
+        {
+            await Task.Yield();
+            Assert.NotEqual(Thread.CurrentThread.ManagedThreadId, NativeTestsPlugin.gameThreadId);
+            var offset = NativeAPI.GetSchemaOffset("CBaseEntity", "m_iHealth");
+            Assert.True(offset > 0);
+        });
     }
 
     [Fact]

managed/CounterStrikeSharp.Tests.Native/TimerTests.cs

@@ -1,3 +1,4 @@
+using System.Collections.Generic;
 using System.Threading.Tasks;
 using CounterStrikeSharp.API;
 using CounterStrikeSharp.API.Core;
@@ -60,6 +61,31 @@ public async Task CreateTimer_RepeatsWithFlag()
         }
     }
 
+    [Fact]
+    public async Task CreateTimer_TickBased()
+    {
+        var startTick = Server.TickCount;
+        var tickCounts = new List<int>();
+        int timesTicked = 0;
+
+        // Run every 4 ticks
+        var timer = new Timer(4 * Server.TickInterval, () =>
+        {
+            timesTicked++;
+            tickCounts.Add(Server.TickCount);
+        }, TimerFlags.REPEAT);
+
+        await Server.RunOnTickAsync(startTick + 16, () => { });
+        timer.Kill();
+
+        Assert.Equal(4, timesTicked);
+        for (int i = 0; i < tickCounts.Count; i++)
+        {
+            var expectedTick = startTick + (i + 1) * 4;
+            Assert.Equal(expectedTick, tickCounts[i]);
+        }
+    }
+
     [Fact]
     public async Task KillTimer_StopsExecution()
     {

src/core/timer_system.cpp

@@ -119,13 +119,7 @@ void TimerSystem::OnGameFrame(bool simulating)
     m_last_ticked_time = globals::getGlobalVars()->curtime;
     m_has_map_ticked = true;
 
-    // Handle timer tick
-    if (timers::universal_time >= timers::timer_next_think)
-    {
-        RunFrame();
-
-        timers::timer_next_think = CalculateNextThink(timers::timer_next_think, 0.1f);
-    }
+    RunFrame();
 
     if (m_on_tick_callback_->GetFunctionCount())
     {
@@ -138,14 +132,11 @@ void TimerSystem::OnGameFrame(bool simulating)
 
 double TimerSystem::CalculateNextThink(double last_think_time, float interval)
 {
-    if (timers::universal_time - last_think_time - interval <= 0.1)
+    if (timers::universal_time - last_think_time - interval <= globals::engine_fixed_tick_interval)
     {
         return last_think_time + interval;
     }
-    else
-    {
-        return timers::universal_time + interval;
-    }
+    return timers::universal_time + interval;
 }
 
 void TimerSystem::RunFrame()

src/mm_plugin.cpp

@@ -55,6 +55,7 @@ DLL_EXPORT void InvokeNative(counterstrikesharp::fxNativeContext& context)
     if (context.nativeIdentifier == 0) return;
 
     if (context.nativeIdentifier != counterstrikesharp::hash_string_const("QUEUE_TASK_FOR_FRAME") &&
+        context.nativeIdentifier != counterstrikesharp::hash_string_const("GET_SCHEMA_OFFSET") &&
         counterstrikesharp::globals::gameThreadId != std::this_thread::get_id())
     {
         counterstrikesharp::ScriptContextRaw scriptContext(context);